Skip to content

ExpandIcon Custom Colors#33148

Merged
shihaohong merged 16 commits intoflutter:masterfrom
shihaohong:expand-icon
May 24, 2019
Merged

ExpandIcon Custom Colors#33148
shihaohong merged 16 commits intoflutter:masterfrom
shihaohong:expand-icon

Conversation

@shihaohong
Copy link
Copy Markdown
Contributor

@shihaohong shihaohong commented May 21, 2019

Description

This takes over #31053

Related Issues

#18992
#21328

Tests

I added the following tests:

  • Tests to verify default light/dark mode ExpandIcon's color and its disabled color
  • Tests to verify ExpandIcon takes custom icon color, expanded icon color, and disabled icon color

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I signed the CLA.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require Flutter developers to manually update their apps to accommodate your change?

@shihaohong shihaohong added framework flutter/packages/flutter repository. See also f: labels. f: material design flutter/packages/flutter/material repository. labels May 21, 2019
@shihaohong shihaohong requested a review from HansMuller May 21, 2019 20:41
@shihaohong shihaohong added the c: new feature Nothing broken; request for a new capability label May 21, 2019
materialTapTargetSize: materialTapTargetSize,
);
disabledColor ??= isDark ? Colors.white30 : Colors.black38;
disabledColor ??= isDark ? Colors.white50 : Colors.black38;
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is likely to have an impact on many apps and tests. Even though it's a tiny change, it would be good to move it to a separate PR.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That makes sense. I'll make the color update into a separate PR

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tracking here: #33149

@shihaohong shihaohong changed the title ExpandIcon Custom Colors WIP ExpandIcon Custom Colors May 22, 2019
@shihaohong shihaohong added the c: API break Backwards-incompatible API changes label May 22, 2019
@shihaohong shihaohong merged commit 9d52085 into flutter:master May 24, 2019
@shihaohong shihaohong deleted the expand-icon branch May 24, 2019 16:06
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

c: API break Backwards-incompatible API changes c: new feature Nothing broken; request for a new capability f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants