ExpandIcon Custom Colors #33148
Merged
ExpandIcon Custom Colors #33148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shihaohong
added
framework
3 tasks
shihaohong
commented
May 21, 2019
HansMuller
approved these changes
May 22, 2019
| @@ -249,7 +249,7 @@ class ThemeData extends Diagnosticable { | |||
| splashColor: splashColor, | |||
| materialTapTargetSize: materialTapTargetSize, | |||
| ); | |||
| disabledColor ??= isDark ? Colors.white30 : Colors.black38; | |||
| disabledColor ??= isDark ? Colors.white50 : Colors.black38; | |||
There was a problem hiding this comment.
This change is likely to have an impact on many apps and tests. Even though it's a tiny change, it would be good to move it to a separate PR.
There was a problem hiding this comment.
That makes sense. I'll make the color update into a separate PR
There was a problem hiding this comment.
Tracking here: #33149
kiku-jw
pushed a commit
to kiku-jw/flutter
that referenced
this pull request
Jun 14, 2019
* Implement ExpandIcon custom color, expandedColor, and disabledColor * Update to use pumpAndSettle instead of hard-coded duration * Update colors to unfocused state, added dark mode test to active state * Fix Colors.white30 doc opacity value * Add links to Material Design specifications to color, expandedColor and disabledColor * Update API docs to reference dark theme material page
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates the dark mode ThemeData.disabledColor value to match the Material Design specification.See Update default colors for enabled/disabled text/iconography #33149This takes over #31053
Related Issues
#18992
#21328
Tests
I added the following tests:
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change
Does your PR require Flutter developers to manually update their apps to accommodate your change?