Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

attempt to not skip coverage on post commit #35246

Merged
merged 2 commits into from Jun 28, 2019

Conversation

@jonahwilliams
Copy link
Contributor

commented Jun 28, 2019

Description

If we skip it post-submit then we have no base coverage to compare to

@googlebot googlebot added the cla: yes label Jun 28, 2019
@jonahwilliams jonahwilliams marked this pull request as ready for review Jun 28, 2019
@jonahwilliams jonahwilliams requested a review from dnfield Jun 28, 2019
@jonahwilliams jonahwilliams merged commit 8de62ab into flutter:master Jun 28, 2019
68 of 69 checks passed
68 of 69 checks passed
tool_coverage-linux Task Summary
Details
WIP Ready for review
Details
add2app-macos Task Summary
Details
add2app-macos
Details
analyze Task Summary
Details
analyze
Details
build_tests-linux Task Summary
Details
build_tests-linux
Details
build_tests-macos Task Summary
Details
build_tests-macos
Details
build_tests-windows Task Summary
Details
build_tests-windows
Details
cla/google All necessary CLAs are signed
deploy_gallery Task Summary
Details
deploy_gallery
Details
deploy_gallery-macos Task Summary
Details
deploy_gallery-macos
Details
docs Task Summary
Details
docs
Details
flutter-build
Details
integration_tests-linux Task Summary
Details
integration_tests-linux
Details
integration_tests-windows Task Summary
Details
integration_tests-windows
Details
integration_tests_gradle1-linux Task Summary
Details
integration_tests_gradle1-linux
Details
integration_tests_gradle2-linux Task Summary
Details
integration_tests_gradle2-linux
Details
release_smoke_tests Task Summary
Details
release_smoke_tests
Details
tests_extras-linux Task Summary
Details
tests_extras-linux
Details
tests_extras-macos Task Summary
Details
tests_extras-macos
Details
tests_extras-windows Task Summary
Details
tests_extras-windows
Details
tests_framework_other-linux Task Summary
Details
tests_framework_other-linux
Details
tests_framework_other-macos Task Summary
Details
tests_framework_other-macos
Details
tests_framework_other-windows Task Summary
Details
tests_framework_other-windows
Details
tests_widgets-linux Task Summary
Details
tests_widgets-linux
Details
tests_widgets-macos Task Summary
Details
tests_widgets-macos
Details
tests_widgets-windows Task Summary
Details
tests_widgets-windows
Details
tool_coverage-linux
Details
tool_tests-linux Task Summary
Details
tool_tests-linux
Details
tool_tests-macos Task Summary
Details
tool_tests-macos
Details
tool_tests-windows Task Summary
Details
tool_tests-windows
Details
tool_tests_create-linux Task Summary
Details
tool_tests_create-linux
Details
tool_tests_create-macos Task Summary
Details
tool_tests_create-macos
Details
tool_tests_create-windows Task Summary
Details
tool_tests_create-windows
Details
tool_tests_integration-linux Task Summary
Details
tool_tests_integration-linux
Details
tool_tests_integration-macos Task Summary
Details
tool_tests_integration-macos
Details
tool_tests_integration-windows Task Summary
Details
tool_tests_integration-windows
Details
web_tests-linux Task Summary
Details
web_tests-linux
Details
@jonahwilliams jonahwilliams deleted the jonahwilliams:dont_skip_master branch Jun 28, 2019
@@ -121,7 +121,7 @@ task:
cpu: 4
memory: 12G
- name: tool_coverage-linux
skip: "!changesInclude('packages/flutter_tools/**/*.dart')"
skip: "!changesInclude('packages/flutter_tools/**/*.dart') || $CIRRUS_BRANCH == 'master'"

This comment has been minimized.

Copy link
@fkorotkov

fkorotkov Jun 28, 2019

Contributor

@jonahwilliams, did you mean to add && $CIRRUS_BRANCH != 'master'?

This comment has been minimized.

Copy link
@jonahwilliams

jonahwilliams Jun 28, 2019

Author Contributor

D'oh

goderbauer added a commit to goderbauer/flutter that referenced this pull request Jul 3, 2019
johnsonmh added a commit to johnsonmh/flutter that referenced this pull request Jul 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.