Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the new service protocol message names #35482

Merged
merged 2 commits into from Jul 2, 2019
Merged

Conversation

a-siva
Copy link
Contributor

@a-siva a-siva commented Jul 2, 2019

Use the new service protocol message names instead of the old private names
clearVMTimeline
setVMTimelineFlags
getVMTimeline
getVMTimelineFlags

  clearVMTimeline
  setVMTimelineFlags
  getVMTimeline
  getVMTimelineFlags
@a-siva a-siva requested a review from bkonyi July 2, 2019 21:05
Copy link
Contributor

@tvolkert tvolkert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@goderbauer
Copy link
Member

Can we submit this to get the tree back to green?

@bkonyi
Copy link
Contributor

bkonyi commented Jul 2, 2019

Can we submit this to get the tree back to green?

I assume we're waiting on the deploy_gallery-macos bots to finish?

@goderbauer
Copy link
Member

goderbauer commented Jul 2, 2019

It seems to have a passing run on cirrus, not sure why it got re-run (twice?) after that?

https://cirrus-ci.com/task/5110686479286272

@a-siva a-siva merged commit f496595 into flutter:master Jul 2, 2019
@a-siva a-siva deleted the fixvmservice branch July 2, 2019 23:10
darrenaustin pushed a commit to darrenaustin/flutter that referenced this pull request Jul 3, 2019
* Use the new service protocol message names
  clearVMTimeline
  setVMTimelineFlags
  getVMTimeline
  getVMTimelineFlags

* Fix clearTimeline at another spot.
tango5614 added a commit to tango5614/flutter that referenced this pull request Jul 4, 2019
* commit 'a0c47e2216a2b50b70c478001cf5652f31a783af': (187 commits)
  Do not use ideographic baseline for RenderPargraph baseline (flutter#35493)
  Add type to StreamChannel in generated test code. (flutter#35367)
  Fix RenderFittedBox when child.size.isEmpty (flutter#35487)
  add APK build time benchmarks (flutter#35481)
  fix Selection handles position is off (flutter#34665)
  Move usage flutter create tests into memory filesystem. (flutter#35160)
  Include tags in SemanticsNode debug properties (flutter#35491)
  Re-apply 'Add currentSystemFrameTimeStamp to SchedulerBinding' (flutter#35492)
  CupertinoTextField vertical alignment (flutter#34723)
  Mark update-packages as non-experimental (flutter#35467)
  fix default artifacts to exclude ios and android (flutter#35303)
  Roll engine ffba2f6..7d3e722 (59 commits) (flutter#35489)
  Update macrobenchmarks README and app name (flutter#35477)
  mark windows and macos chrome dev mode as flaky (flutter#35495)
  Use the new service protocol message names (flutter#35482)
  Manual roll of engine 45b66b7...ffba2f6 (flutter#35464)
  more ui-as-code (flutter#35393)
  update reassemble doc (flutter#35164)
  New parameter for RawGestureDetector to customize semantics mapping (flutter#33936)
  Add --target support for Windows and Linux (flutter#34660)
  ...
johnsonmh pushed a commit to johnsonmh/flutter that referenced this pull request Jul 30, 2019
* Use the new service protocol message names
  clearVMTimeline
  setVMTimelineFlags
  getVMTimeline
  getVMTimelineFlags

* Fix clearTimeline at another spot.
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants