Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor fixes to precache help text (attempt #2) #36331

Merged
merged 1 commit into from Jul 17, 2019

Conversation

@timsneath
Copy link
Member

commented Jul 17, 2019

Description

Noticed a spelling error on the flutter precache command help text, and took the opportunity to tidy up the capitalization and trailing periods to be consistent with flutter help. Finally, clarified the difference between --all-platforms and --universal

Related Issues

None

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I signed the [CLA].
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require Flutter developers to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (Please read [Handling breaking changes]). Replace this with a link to the e-mail where you asked for input on this proposed change.
  • No, this is not a breaking change.
@fluttergithubbot

This comment has been minimized.

Copy link

commented Jul 17, 2019

It looks like this pull request may not have tests. Please make sure to add tests before merging. While there are exceptions to this rule, if this patch modifies code it is probably not an exception.

Reviewers: Read the Tree Hygine page and make sure this patch meets those guidelines before LGTMing.

/cc @dnfield

@googlebot googlebot added the cla: yes label Jul 17, 2019
@timsneath timsneath referenced this pull request Jul 17, 2019
8 of 9 tasks complete
@codecov

This comment has been minimized.

Copy link

commented Jul 17, 2019

Codecov Report

Merging #36331 into master will decrease coverage by 1%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #36331      +/-   ##
==========================================
- Coverage   55.28%   54.28%   -1.01%     
==========================================
  Files         188      188              
  Lines       17320    17320              
==========================================
- Hits         9576     9402     -174     
- Misses       7744     7918     +174
Flag Coverage Δ
#flutter_tool 54.28% <ø> (-1.01%) ⬇️
Impacted Files Coverage Δ
packages/flutter_tools/lib/src/cache.dart 50.9% <ø> (ø) ⬆️
...kages/flutter_tools/lib/src/commands/precache.dart 91.3% <ø> (ø) ⬆️
...s/flutter_tools/lib/src/macos/xcode_validator.dart 4.76% <0%> (-85.72%) ⬇️
...s/flutter_tools/lib/src/tester/flutter_tester.dart 5.2% <0%> (-66.67%) ⬇️
packages/flutter_tools/lib/src/bundle.dart 35% <0%> (-48.34%) ⬇️
...lutter_tools/lib/src/android/android_workflow.dart 31.37% <0%> (-33.34%) ⬇️
...ages/flutter_tools/lib/src/base/user_messages.dart 40.38% <0%> (-9.62%) ⬇️
packages/flutter_tools/lib/src/version.dart 95.07% <0%> (-2.47%) ⬇️
packages/flutter_tools/lib/src/device.dart 67.04% <0%> (-0.57%) ⬇️
.../flutter_tools/lib/src/fuchsia/fuchsia_device.dart 55.39% <0%> (-0.38%) ⬇️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9b08eff...2decacd. Read the comment docs.

Copy link
Contributor

left a comment

LGTM

@jonahwilliams

This comment has been minimized.

Copy link
Contributor

commented Jul 17, 2019

Should be good to ignore codecov, I fixed it recently but you might not have picked up that commit

@timsneath timsneath merged commit 0773557 into flutter:master Jul 17, 2019
76 of 77 checks passed
76 of 77 checks passed
codecov/project 54.28% (-1.01%) compared to 9b08eff
Details
WIP Ready for review
Details
add2app-macos Task Summary
Details
add2app-macos
Details
analyze Task Summary
Details
analyze
Details
build_tests-linux Task Summary
Details
build_tests-linux
Details
build_tests-macos Task Summary
Details
build_tests-macos
Details
build_tests-windows Task Summary
Details
build_tests-windows
Details
cla/google All necessary CLAs are signed
codecov/patch Coverage not affected when comparing 9b08eff...2decacd
Details
customer_testing-linux Task Summary
Details
customer_testing-linux
Details
customer_testing-macos Task Summary
Details
customer_testing-macos
Details
customer_testing-windows Task Summary
Details
customer_testing-windows
Details
deploy_gallery Task Summary
Details
deploy_gallery
Details
deploy_gallery-macos Task Summary
Details
deploy_gallery-macos
Details
docs Task Summary
Details
docs
Details
flutter-build
Details
integration_tests-linux Task Summary
Details
integration_tests-linux
Details
integration_tests-macos Task Summary
Details
integration_tests-macos
Details
integration_tests-windows Task Summary
Details
integration_tests-windows
Details
integration_tests_gradle1-linux Task Summary
Details
integration_tests_gradle1-linux
Details
integration_tests_gradle2-linux Task Summary
Details
integration_tests_gradle2-linux
Details
release_smoke_tests Task Summary
Details
release_smoke_tests
Details
tests_extras-linux Task Summary
Details
tests_extras-linux
Details
tests_extras-macos Task Summary
Details
tests_extras-macos
Details
tests_extras-windows Task Summary
Details
tests_extras-windows
Details
tests_framework_other-linux Task Summary
Details
tests_framework_other-linux
Details
tests_framework_other-macos Task Summary
Details
tests_framework_other-macos
Details
tests_framework_other-windows Task Summary
Details
tests_framework_other-windows
Details
tests_widgets-linux Task Summary
Details
tests_widgets-linux
Details
tests_widgets-macos Task Summary
Details
tests_widgets-macos
Details
tests_widgets-windows Task Summary
Details
tests_widgets-windows
Details
tool_coverage-linux Task Summary
Details
tool_coverage-linux
Details
tool_tests-linux Task Summary
Details
tool_tests-linux
Details
tool_tests-macos Task Summary
Details
tool_tests-macos
Details
tool_tests-windows Task Summary
Details
tool_tests-windows
Details
tool_tests_create-linux Task Summary
Details
tool_tests_create-linux
Details
tool_tests_create-macos Task Summary
Details
tool_tests_create-macos
Details
tool_tests_create-windows Task Summary
Details
tool_tests_create-windows
Details
tool_tests_integration-linux Task Summary
Details
tool_tests_integration-linux
Details
tool_tests_integration-macos Task Summary
Details
tool_tests_integration-macos
Details
tool_tests_integration-windows Task Summary
Details
tool_tests_integration-windows
Details
@timsneath timsneath deleted the timsneath:timsneath-precache2 branch Jul 17, 2019
johnsonmh added a commit to johnsonmh/flutter that referenced this pull request Jul 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.