Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up flutter driver device detection. #36434

Merged
merged 6 commits into from Jul 19, 2019

Conversation

@jonahwilliams
Copy link
Contributor

commented Jul 18, 2019

Description

Prevent drive from attempting to launch/display on unsupported devices. Cleans up some injected interfaces to be correctly named.

#36049

@jonahwilliams jonahwilliams added the tool label Jul 18, 2019
@googlebot googlebot added the cla: yes label Jul 18, 2019
@codecov

This comment has been minimized.

Copy link

commented Jul 18, 2019

Codecov Report

Merging #36434 into master will increase coverage by 0.98%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #36434      +/-   ##
==========================================
+ Coverage   54.69%   55.68%   +0.98%     
==========================================
  Files         188      188              
  Lines       17367    17365       -2     
==========================================
+ Hits         9499     9669     +170     
+ Misses       7868     7696     -172
Flag Coverage Δ
#flutter_tool 55.68% <100%> (+0.98%) ⬆️
Impacted Files Coverage Δ
packages/flutter_tools/lib/src/commands/drive.dart 74.57% <100%> (+1.24%) ⬆️
packages/flutter_tools/lib/src/base/net.dart 0% <0%> (-89.75%) ⬇️
packages/flutter_tools/lib/src/version.dart 96.05% <0%> (-1.48%) ⬇️
packages/flutter_tools/lib/src/emulator.dart 69.49% <0%> (-0.85%) ⬇️
.../flutter_tools/lib/src/android/android_device.dart 33.5% <0%> (-0.26%) ⬇️
packages/flutter_tools/lib/src/vmservice.dart 38.97% <0%> (-0.16%) ⬇️
packages/flutter_tools/lib/src/base/process.dart 83.59% <0%> (ø) ⬆️
packages/flutter_tools/lib/src/base/logger.dart 84.49% <0%> (ø) ⬆️
.../flutter_tools/lib/src/fuchsia/fuchsia_device.dart 55.76% <0%> (+0.37%) ⬆️
packages/flutter_tools/lib/src/build_info.dart 70.71% <0%> (+0.55%) ⬆️
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 82a4ba4...eb14448. Read the comment docs.

…tter into flutter_driver_isolate
@jonahwilliams jonahwilliams requested a review from yjbanov Jul 19, 2019
Copy link
Contributor

left a comment

lgtm

@jonahwilliams jonahwilliams merged commit 6830edd into flutter:master Jul 19, 2019
77 checks passed
77 checks passed
WIP Ready for review
Details
add2app-macos Task Summary
Details
add2app-macos
Details
analyze Task Summary
Details
analyze
Details
build_tests-linux Task Summary
Details
build_tests-linux
Details
build_tests-macos Task Summary
Details
build_tests-macos
Details
build_tests-windows Task Summary
Details
build_tests-windows
Details
cla/google All necessary CLAs are signed
codecov/patch 100% of diff hit (target 54.69%)
Details
codecov/project 55.68% (+0.98%) compared to 82a4ba4
Details
customer_testing-linux Task Summary
Details
customer_testing-linux
Details
customer_testing-macos Task Summary
Details
customer_testing-macos
Details
customer_testing-windows Task Summary
Details
customer_testing-windows
Details
deploy_gallery Task Summary
Details
deploy_gallery
Details
deploy_gallery-macos Task Summary
Details
deploy_gallery-macos
Details
docs Task Summary
Details
docs
Details
flutter-build
Details
integration_tests-linux Task Summary
Details
integration_tests-linux
Details
integration_tests-macos Task Summary
Details
integration_tests-macos
Details
integration_tests-windows Task Summary
Details
integration_tests-windows
Details
integration_tests_gradle1-linux Task Summary
Details
integration_tests_gradle1-linux
Details
integration_tests_gradle2-linux Task Summary
Details
integration_tests_gradle2-linux
Details
release_smoke_tests Task Summary
Details
release_smoke_tests
Details
tests_extras-linux Task Summary
Details
tests_extras-linux
Details
tests_extras-macos Task Summary
Details
tests_extras-macos
Details
tests_extras-windows Task Summary
Details
tests_extras-windows
Details
tests_framework_other-linux Task Summary
Details
tests_framework_other-linux
Details
tests_framework_other-macos Task Summary
Details
tests_framework_other-macos
Details
tests_framework_other-windows Task Summary
Details
tests_framework_other-windows
Details
tests_widgets-linux Task Summary
Details
tests_widgets-linux
Details
tests_widgets-macos Task Summary
Details
tests_widgets-macos
Details
tests_widgets-windows Task Summary
Details
tests_widgets-windows
Details
tool_coverage-linux Task Summary
Details
tool_coverage-linux
Details
tool_tests-linux Task Summary
Details
tool_tests-linux
Details
tool_tests-macos Task Summary
Details
tool_tests-macos
Details
tool_tests-windows Task Summary
Details
tool_tests-windows
Details
tool_tests_create-linux Task Summary
Details
tool_tests_create-linux
Details
tool_tests_create-macos Task Summary
Details
tool_tests_create-macos
Details
tool_tests_create-windows Task Summary
Details
tool_tests_create-windows
Details
tool_tests_integration-linux Task Summary
Details
tool_tests_integration-linux
Details
tool_tests_integration-macos Task Summary
Details
tool_tests_integration-macos
Details
tool_tests_integration-windows Task Summary
Details
tool_tests_integration-windows
Details
@jonahwilliams jonahwilliams deleted the jonahwilliams:flutter_driver_isolate branch Jul 19, 2019
johnsonmh added a commit to johnsonmh/flutter that referenced this pull request Jul 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.