Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose functionality to compile dart to kernel for the VM #36598

Merged
merged 6 commits into from Jul 27, 2019

Conversation

@jonahwilliams
Copy link
Contributor

commented Jul 20, 2019

Description

This is intended to be used instead of snapshotting for the 3p tool extensions. Also removes unused incrementalBytesStorePath argument.

@codecov

This comment has been minimized.

Copy link

commented Jul 20, 2019

Codecov Report

Merging #36598 into master will decrease coverage by 1.11%.
The diff coverage is 75%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #36598      +/-   ##
==========================================
- Coverage   55.95%   54.83%   -1.12%     
==========================================
  Files         188      188              
  Lines       17432    17412      -20     
==========================================
- Hits         9754     9548     -206     
- Misses       7678     7864     +186
Flag Coverage Δ
#flutter_tool 54.83% <75%> (-1.12%) ⬇️
Impacted Files Coverage Δ
packages/flutter_tools/lib/src/codegen.dart 8.33% <ø> (ø) ⬆️
packages/flutter_tools/lib/src/compile.dart 79.44% <75%> (+4.35%) ⬆️
packages/flutter_tools/lib/src/commands/run.dart 19.13% <0%> (-42.59%) ⬇️
packages/flutter_tools/lib/src/base/build.dart 44.88% <0%> (-28.98%) ⬇️
packages/flutter_tools/lib/src/ios/devices.dart 16.66% <0%> (-20.42%) ⬇️
...ackages/flutter_tools/lib/src/reporting/usage.dart 69.84% <0%> (-16.08%) ⬇️
packages/flutter_tools/lib/src/run_cold.dart 0% <0%> (-10.39%) ⬇️
packages/flutter_tools/lib/src/convert.dart 75% <0%> (-8.34%) ⬇️
packages/flutter_tools/lib/src/artifacts.dart 64.98% <0%> (-3.25%) ⬇️
.../flutter_tools/lib/src/runner/flutter_command.dart 80.8% <0%> (-1.79%) ⬇️
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6cdb4dd...37dc165. Read the comment docs.

@jonahwilliams jonahwilliams force-pushed the jonahwilliams:compile_dart_code branch from 6c64071 to 2629e0b Jul 20, 2019
@jonahwilliams

This comment has been minimized.

Copy link
Contributor Author

commented Jul 20, 2019

FYI @fkorotkov lots of tasks on my PRs are hitting a "Fetch failed with a timeout!" issue when trying to fetch

@fkorotkov

This comment has been minimized.

Copy link
Contributor

commented Jul 20, 2019

@jonahwilliams weird. I've tweaked some setting will see if it will mitigate occasional network slowness

@jonahwilliams jonahwilliams marked this pull request as ready for review Jul 23, 2019
@jonahwilliams jonahwilliams requested review from dnfield and zanderso Jul 23, 2019
@jonahwilliams jonahwilliams merged commit 51d2d35 into flutter:master Jul 27, 2019
77 checks passed
77 checks passed
WIP Ready for review
Details
add2app-macos Task Summary
Details
add2app-macos
Details
analyze Task Summary
Details
analyze
Details
build_tests-linux Task Summary
Details
build_tests-linux
Details
build_tests-macos Task Summary
Details
build_tests-macos
Details
build_tests-windows Task Summary
Details
build_tests-windows
Details
cla/google All necessary CLAs are signed
codecov/patch 75% of diff hit (target 55.95%)
Details
codecov/project Absolute coverage decreased by -1.11% but relative coverage increased by +19.04% compared to 6cdb4dd
Details
customer_testing-linux Task Summary
Details
customer_testing-linux
Details
customer_testing-macos Task Summary
Details
customer_testing-macos
Details
customer_testing-windows Task Summary
Details
customer_testing-windows
Details
deploy_gallery Task Summary
Details
deploy_gallery
Details
deploy_gallery-macos Task Summary
Details
deploy_gallery-macos
Details
docs Task Summary
Details
docs
Details
flutter-build
Details
integration_tests-linux Task Summary
Details
integration_tests-linux
Details
integration_tests-macos Task Summary
Details
integration_tests-macos
Details
integration_tests-windows Task Summary
Details
integration_tests-windows
Details
integration_tests_gradle1-linux Task Summary
Details
integration_tests_gradle1-linux
Details
integration_tests_gradle2-linux Task Summary
Details
integration_tests_gradle2-linux
Details
release_smoke_tests Task Summary
Details
release_smoke_tests
Details
tests_extras-linux Task Summary
Details
tests_extras-linux
Details
tests_extras-macos Task Summary
Details
tests_extras-macos
Details
tests_extras-windows Task Summary
Details
tests_extras-windows
Details
tests_framework_other-linux Task Summary
Details
tests_framework_other-linux
Details
tests_framework_other-macos Task Summary
Details
tests_framework_other-macos
Details
tests_framework_other-windows Task Summary
Details
tests_framework_other-windows
Details
tests_widgets-linux Task Summary
Details
tests_widgets-linux
Details
tests_widgets-macos Task Summary
Details
tests_widgets-macos
Details
tests_widgets-windows Task Summary
Details
tests_widgets-windows
Details
tool_coverage-linux Task Summary
Details
tool_coverage-linux
Details
tool_tests-linux Task Summary
Details
tool_tests-linux
Details
tool_tests-macos Task Summary
Details
tool_tests-macos
Details
tool_tests-windows Task Summary
Details
tool_tests-windows
Details
tool_tests_create-linux Task Summary
Details
tool_tests_create-linux
Details
tool_tests_create-macos Task Summary
Details
tool_tests_create-macos
Details
tool_tests_create-windows Task Summary
Details
tool_tests_create-windows
Details
tool_tests_integration-linux Task Summary
Details
tool_tests_integration-linux
Details
tool_tests_integration-macos Task Summary
Details
tool_tests_integration-macos
Details
tool_tests_integration-windows Task Summary
Details
tool_tests_integration-windows
Details
@jonahwilliams jonahwilliams deleted the jonahwilliams:compile_dart_code branch Jul 27, 2019
johnsonmh added a commit to johnsonmh/flutter that referenced this pull request Jul 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.