Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[flutter_tool] Usage refactor cleanup #37186

Merged
merged 1 commit into from Jul 30, 2019

Conversation

@zanderso
Copy link
Contributor

commented Jul 29, 2019

Description

This PR has two missing cleanups from the Usage refactor PR:

  • It adds a test that full restart sends the target platform in the usage event
  • It decomposes GroupedValidators when sending their events.

Tests

I added the following tests:

Tests in resident_runner_test.dart and doctor_test.dart.

Breaking Change

Does your PR require Flutter developers to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (Please read [Handling breaking changes]). Replace this with a link to the e-mail where you asked for input on this proposed change.
  • No, this is not a breaking change.
@googlebot googlebot added the cla: yes label Jul 29, 2019
@zanderso zanderso added tool and removed cla: yes labels Jul 29, 2019
@googlebot googlebot added the cla: yes label Jul 29, 2019
@codecov

This comment has been minimized.

Copy link

commented Jul 29, 2019

Codecov Report

Merging #37186 into master will increase coverage by 0.33%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #37186      +/-   ##
==========================================
+ Coverage   54.55%   54.89%   +0.33%     
==========================================
  Files         193      193              
  Lines       17849    17859      +10     
==========================================
+ Hits         9738     9804      +66     
+ Misses       8111     8055      -56
Flag Coverage Δ
#flutter_tool 54.89% <100%> (+0.33%) ⬆️
Impacted Files Coverage Δ
...ckages/flutter_tools/lib/src/reporting/events.dart 98.21% <100%> (+0.29%) ⬆️
packages/flutter_tools/lib/src/doctor.dart 70.05% <100%> (+0.18%) ⬆️
...s/flutter_tools/lib/src/tester/flutter_tester.dart 5.15% <0%> (-65.98%) ⬇️
packages/flutter_tools/lib/src/bundle.dart 31.81% <0%> (-43.94%) ⬇️
packages/flutter_tools/lib/src/device.dart 55.42% <0%> (-1.81%) ⬇️
packages/flutter_tools/lib/src/cache.dart 41.83% <0%> (-0.77%) ⬇️
packages/flutter_tools/lib/src/version.dart 90.73% <0%> (+0.48%) ⬆️
packages/flutter_tools/lib/src/base/process.dart 80.46% <0%> (+0.78%) ⬆️
packages/flutter_tools/lib/src/build_info.dart 70.71% <0%> (+1.65%) ⬆️
packages/flutter_tools/lib/src/run_hot.dart 68.7% <0%> (+1.96%) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c8be195...6a01b1c. Read the comment docs.

@zanderso zanderso requested a review from jonahwilliams Jul 30, 2019
Copy link
Contributor

left a comment

LGTM

@zanderso zanderso merged commit d208ce2 into flutter:master Jul 30, 2019
81 checks passed
81 checks passed
WIP Ready for review
Details
add2app-macos Task Summary
Details
add2app-macos
Details
analyze Task Summary
Details
analyze
Details
build_tests-linux Task Summary
Details
build_tests-linux
Details
build_tests-macos Task Summary
Details
build_tests-macos
Details
build_tests-windows Task Summary
Details
build_tests-windows
Details
cla/google All necessary CLAs are signed
codecov/patch 100% of diff hit (target 54.55%)
Details
codecov/project 54.89% (+0.33%) compared to c8be195
Details
customer_testing-linux Task Summary
Details
customer_testing-linux
Details
customer_testing-macos Task Summary
Details
customer_testing-macos
Details
customer_testing-windows Task Summary
Details
customer_testing-windows
Details
deploy_gallery Task Summary
Details
deploy_gallery
Details
deploy_gallery-macos Task Summary
Details
deploy_gallery-macos
Details
docs Task Summary
Details
docs
Details
flutter-build
Details
integration_tests-linux Task Summary
Details
integration_tests-linux
Details
integration_tests-macos Task Summary
Details
integration_tests-macos
Details
integration_tests-windows Task Summary
Details
integration_tests-windows
Details
integration_tests_gradle1-linux Task Summary
Details
integration_tests_gradle1-linux
Details
integration_tests_gradle1-windows Task Summary
Details
integration_tests_gradle1-windows
Details
integration_tests_gradle2-linux Task Summary
Details
integration_tests_gradle2-linux
Details
integration_tests_gradle2-windows Task Summary
Details
integration_tests_gradle2-windows
Details
release_smoke_tests Task Summary
Details
release_smoke_tests
Details
tests_extras-linux Task Summary
Details
tests_extras-linux
Details
tests_extras-macos Task Summary
Details
tests_extras-macos
Details
tests_extras-windows Task Summary
Details
tests_extras-windows
Details
tests_framework_other-linux Task Summary
Details
tests_framework_other-linux
Details
tests_framework_other-macos Task Summary
Details
tests_framework_other-macos
Details
tests_framework_other-windows Task Summary
Details
tests_framework_other-windows
Details
tests_widgets-linux Task Summary
Details
tests_widgets-linux
Details
tests_widgets-macos Task Summary
Details
tests_widgets-macos
Details
tests_widgets-windows Task Summary
Details
tests_widgets-windows
Details
tool_coverage-linux Task Summary
Details
tool_coverage-linux
Details
tool_tests-linux Task Summary
Details
tool_tests-linux
Details
tool_tests-macos Task Summary
Details
tool_tests-macos
Details
tool_tests-windows Task Summary
Details
tool_tests-windows
Details
tool_tests_create-linux Task Summary
Details
tool_tests_create-linux
Details
tool_tests_create-macos Task Summary
Details
tool_tests_create-macos
Details
tool_tests_create-windows Task Summary
Details
tool_tests_create-windows
Details
tool_tests_integration-linux Task Summary
Details
tool_tests_integration-linux
Details
tool_tests_integration-macos Task Summary
Details
tool_tests_integration-macos
Details
tool_tests_integration-windows Task Summary
Details
tool_tests_integration-windows
Details
@zanderso zanderso deleted the zanderso:more-analytics-cleanup branch Jul 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.