Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #37593 Add flutter_export_environment.sh to gitignore #37595

Merged
merged 1 commit into from Aug 6, 2019

Conversation

@walsha2
Copy link
Contributor

commented Aug 5, 2019

Description

Closes #37593 - Please see that issue description.

Tests

Manually tested to confirm that .gitignore templates with changes are implemented when using flutter create

Checklist

All tasks completed:

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I signed the [CLA].
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.
@googlebot googlebot added the cla: yes label Aug 5, 2019
@jmagman jmagman self-requested a review Aug 5, 2019
Copy link
Member

left a comment

This also needs to be changed in:
dev/integration_tests/android_splash_screens/splash_screen_kitchen_sink/.gitignore
dev/integration_tests/android_splash_screens/splash_screen_load_rotate/.gitignore
dev/integration_tests/android_splash_screens/splash_screen_trans_rotate/.gitignore
dev/integration_tests/android_views/ios/.gitignore
dev/integration_tests/release_smoke_test/.gitignore
packages/flutter_tools/templates/plugin/ios.tmpl/.gitignore

@walsha2

This comment has been minimized.

Copy link
Contributor Author

commented Aug 5, 2019

@jmagman copy. Will make that change later and push back up.

@walsha2 walsha2 force-pushed the walsha2:37593-flutter-export-env-gitignore branch from 5486e78 to b2a5c68 Aug 5, 2019
@walsha2

This comment has been minimized.

Copy link
Contributor Author

commented Aug 5, 2019

@jmagman complete.

@jmagman
jmagman approved these changes Aug 5, 2019
Copy link
Member

left a comment

Thank you! LGTM!

@jmagman

This comment has been minimized.

Copy link
Member

commented Aug 6, 2019

This is ready to merge!

@walsha2

This comment has been minimized.

Copy link
Contributor Author

commented Aug 6, 2019

The general process for submitting code to a Flutter repository is as follows:
....
8. Once everything is green and you have an LGTM, land your patch.

@jmagman I'm not sure who or how step 8 above (from contribute section of Wiki) is performed.

Or is that because the testing pipeline is showing "Flutter build is currently broken"? Im not sure why that is... Tests should all be passing.

@jmagman

This comment has been minimized.

Copy link
Member

commented Aug 6, 2019

The general process for submitting code to a Flutter repository is as follows:
....
8. Once everything is green and you have an LGTM, land your patch.

@jmagman I'm not sure who or how step 8 above (from contribute section of Wiki) is performed.

Or is that because the testing pipeline is showing "Flutter build is currently broken"? Im not sure why that is... Tests should all be passing.

When I made that comment "flutter-build" was green. Looks like the CI system is red though (not due to your change). When it goes green again, please squash and merge!

@jmagman jmagman merged commit 107f365 into flutter:master Aug 6, 2019
78 of 79 checks passed
78 of 79 checks passed
tool_coverage-linux Task Summary
Details
WIP Ready for review
Details
add2app-macos Task Summary
Details
add2app-macos
Details
analyze Task Summary
Details
analyze
Details
build_tests-linux Task Summary
Details
build_tests-linux
Details
build_tests-macos Task Summary
Details
build_tests-macos
Details
build_tests-windows Task Summary
Details
build_tests-windows
Details
cla/google All necessary CLAs are signed
customer_testing-linux Task Summary
Details
customer_testing-linux
Details
customer_testing-macos Task Summary
Details
customer_testing-macos
Details
customer_testing-windows Task Summary
Details
customer_testing-windows
Details
deploy_gallery Task Summary
Details
deploy_gallery
Details
deploy_gallery-macos Task Summary
Details
deploy_gallery-macos
Details
docs Task Summary
Details
docs
Details
flutter-build
Details
integration_tests-linux Task Summary
Details
integration_tests-linux
Details
integration_tests-macos Task Summary
Details
integration_tests-macos
Details
integration_tests-windows Task Summary
Details
integration_tests-windows
Details
integration_tests_gradle1-linux Task Summary
Details
integration_tests_gradle1-linux
Details
integration_tests_gradle1-windows Task Summary
Details
integration_tests_gradle1-windows
Details
integration_tests_gradle2-linux Task Summary
Details
integration_tests_gradle2-linux
Details
integration_tests_gradle2-windows Task Summary
Details
integration_tests_gradle2-windows
Details
release_smoke_tests Task Summary
Details
release_smoke_tests
Details
tests_extras-linux Task Summary
Details
tests_extras-linux
Details
tests_extras-macos Task Summary
Details
tests_extras-macos
Details
tests_extras-windows Task Summary
Details
tests_extras-windows
Details
tests_framework_other-linux Task Summary
Details
tests_framework_other-linux
Details
tests_framework_other-macos Task Summary
Details
tests_framework_other-macos
Details
tests_framework_other-windows Task Summary
Details
tests_framework_other-windows
Details
tests_widgets-linux Task Summary
Details
tests_widgets-linux
Details
tests_widgets-macos Task Summary
Details
tests_widgets-macos
Details
tests_widgets-windows Task Summary
Details
tests_widgets-windows
Details
tool_coverage-linux
Details
tool_tests-linux Task Summary
Details
tool_tests-linux
Details
tool_tests-macos Task Summary
Details
tool_tests-macos
Details
tool_tests-windows Task Summary
Details
tool_tests-windows
Details
tool_tests_create-linux Task Summary
Details
tool_tests_create-linux
Details
tool_tests_create-macos Task Summary
Details
tool_tests_create-macos
Details
tool_tests_create-windows Task Summary
Details
tool_tests_create-windows
Details
tool_tests_integration-linux Task Summary
Details
tool_tests_integration-linux
Details
tool_tests_integration-macos Task Summary
Details
tool_tests_integration-macos
Details
tool_tests_integration-windows Task Summary
Details
tool_tests_integration-windows
Details
@jmagman

This comment has been minimized.

Copy link
Member

commented Aug 6, 2019

I merged it. Thanks @walsha2!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.