Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove no-constant-update-2018, the underlying issue has been resolved. #37994

Merged
merged 1 commit into from Aug 12, 2019

Conversation

@chingjun
Copy link
Contributor

commented Aug 10, 2019

According to @a-siva , issue dart-lang/sdk#36584 has been resolved and this can be removed.

I've personally tried to run the sample app without any issues.

@fluttergithubbot

This comment has been minimized.

Copy link

commented Aug 10, 2019

It looks like this pull request may not have tests. Please make sure to add tests before merging. While there are exceptions to this rule, if this patch modifies code it is probably not an exception.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@googlebot googlebot added the cla: yes label Aug 10, 2019
@chingjun chingjun requested a review from zanderso Aug 10, 2019
@codecov

This comment has been minimized.

Copy link

commented Aug 10, 2019

Codecov Report

Merging #37994 into master will increase coverage by 0.37%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #37994      +/-   ##
==========================================
+ Coverage   55.49%   55.87%   +0.37%     
==========================================
  Files         194      194              
  Lines       18174    18174              
==========================================
+ Hits        10086    10155      +69     
+ Misses       8088     8019      -69
Flag Coverage Δ
#flutter_tool 55.87% <ø> (+0.37%) ⬆️
Impacted Files Coverage Δ
...tools/lib/src/fuchsia/fuchsia_kernel_compiler.dart 7.69% <ø> (ø) ⬆️
packages/flutter_tools/lib/src/web/compile.dart 9.09% <0%> (-69.7%) ⬇️
...ages/flutter_tools/lib/src/commands/build_web.dart 30.76% <0%> (-30.77%) ⬇️
...ages/flutter_tools/lib/src/commands/build_aot.dart 17.34% <0%> (-18.37%) ⬇️
packages/flutter_tools/lib/src/cache.dart 43.5% <0%> (-0.73%) ⬇️
.../flutter_tools/lib/src/fuchsia/fuchsia_device.dart 55.39% <0%> (+0.37%) ⬆️
packages/flutter_tools/lib/src/build_info.dart 69.61% <0%> (+0.55%) ⬆️
packages/flutter_tools/lib/src/base/process.dart 80.46% <0%> (+0.78%) ⬆️
.../flutter_tools/lib/src/android/android_device.dart 34% <0%> (+2%) ⬆️
...ages/flutter_tools/lib/src/linux/linux_device.dart 43.47% <0%> (+2.17%) ⬆️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c7814d6...856f740. Read the comment docs.

@chingjun chingjun merged commit cdefbef into flutter:master Aug 12, 2019
70 of 71 checks passed
70 of 71 checks passed
docs Task Summary
Details
WIP Ready for review
Details
add2app-macos Task Summary
Details
add2app-macos
Details
analyze Task Summary
Details
analyze
Details
build_tests-linux Task Summary
Details
build_tests-linux
Details
build_tests-windows Task Summary
Details
build_tests-windows
Details
cla/google All necessary CLAs are signed
codecov/patch Coverage not affected when comparing c7814d6...856f740
Details
codecov/project 55.87% (+0.37%) compared to c7814d6
Details
customer_testing-linux Task Summary
Details
customer_testing-linux
Details
customer_testing-macos Task Summary
Details
customer_testing-macos
Details
customer_testing-windows Task Summary
Details
customer_testing-windows
Details
deploy_gallery Task Summary
Details
deploy_gallery
Details
deploy_gallery-macos Task Summary
Details
deploy_gallery-macos
Details
docs
Details
flutter-build
Details
integration_tests-linux Task Summary
Details
integration_tests-linux
Details
integration_tests-windows Task Summary
Details
integration_tests-windows
Details
integration_tests_gradle1-linux Task Summary
Details
integration_tests_gradle1-linux
Details
integration_tests_gradle1-windows Task Summary
Details
integration_tests_gradle1-windows
Details
integration_tests_gradle2-linux Task Summary
Details
integration_tests_gradle2-linux
Details
integration_tests_gradle2-windows Task Summary
Details
integration_tests_gradle2-windows
Details
release_smoke_tests Task Summary
Details
release_smoke_tests
Details
tests_extras-linux Task Summary
Details
tests_extras-linux
Details
tests_extras-windows Task Summary
Details
tests_extras-windows
Details
tests_framework_other-linux Task Summary
Details
tests_framework_other-linux
Details
tests_framework_other-windows Task Summary
Details
tests_framework_other-windows
Details
tests_widgets-linux Task Summary
Details
tests_widgets-linux
Details
tests_widgets-windows Task Summary
Details
tests_widgets-windows
Details
tool_coverage-linux Task Summary
Details
tool_coverage-linux
Details
tool_tests-linux Task Summary
Details
tool_tests-linux
Details
tool_tests-macos Task Summary
Details
tool_tests-macos
Details
tool_tests-windows Task Summary
Details
tool_tests-windows
Details
tool_tests_create-linux Task Summary
Details
tool_tests_create-linux
Details
tool_tests_create-macos Task Summary
Details
tool_tests_create-macos
Details
tool_tests_create-windows Task Summary
Details
tool_tests_create-windows
Details
tool_tests_integration-linux Task Summary
Details
tool_tests_integration-linux
Details
tool_tests_integration-windows Task Summary
Details
tool_tests_integration-windows
Details
web_tests-linux Task Summary
Details
web_tests-linux
Details
@a-siva

This comment has been minimized.

Copy link
Contributor

commented Aug 13, 2019

There still seems to be one reference left for this in
topaz/runtime/dart/dart_kernel.gni
147: # Remove when new constant eval supports dilp files.
148: "--enable-experiment=no-constant-update-2018",

@chingjun

This comment has been minimized.

Copy link
Contributor Author

commented Aug 13, 2019

@a-siva

This comment has been minimized.

Copy link
Contributor

commented Aug 13, 2019

Thanks for taking care of this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.