Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PlatformViewLink: Rename CreatePlatformViewController to CreatePlatformViewCallback #38710

Merged
merged 1 commit into from Aug 16, 2019

Conversation

@cyanglaz
Copy link
Contributor

commented Aug 16, 2019

Description

Some renaming to match the naming convention.

Related Issues

Tests

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I signed the CLA.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require Flutter developers to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (Please read Handling breaking changes). Replace this with a link to the e-mail where you asked for input on this proposed change.
  • No, this is not a breaking change.
@amirh

This comment has been minimized.

Copy link
Contributor

commented Aug 16, 2019

Note that this is a breaking change.
However since PlatformViewLink only landed yesterday, and it's hard to believe that anyone is using it already I think it's reasonable to skip the breaking change policy.

Giving @Hixie a chance to stop us.

@amirh
amirh approved these changes Aug 16, 2019
Copy link
Contributor

left a comment

LGTM

@cyanglaz cyanglaz merged commit 09f6515 into flutter:master Aug 16, 2019
60 of 69 checks passed
60 of 69 checks passed
tool_coverage-linux Task Summary
Details
tool_tests-linux Task Summary
Details
tool_tests-macos Task Summary
Details
tool_tests-windows Task Summary
Details
tool_tests_create-linux Task Summary
Details
tool_tests_create-macos Task Summary
Details
tool_tests_create-windows Task Summary
Details
tool_tests_integration-linux Task Summary
Details
tool_tests_integration-windows Task Summary
Details
WIP Ready for review
Details
add2app-macos Task Summary
Details
add2app-macos
Details
analyze Task Summary
Details
analyze
Details
build_tests-linux Task Summary
Details
build_tests-linux
Details
build_tests-windows Task Summary
Details
build_tests-windows
Details
cla/google All necessary CLAs are signed
customer_testing-linux Task Summary
Details
customer_testing-linux
Details
customer_testing-macos Task Summary
Details
customer_testing-macos
Details
customer_testing-windows Task Summary
Details
customer_testing-windows
Details
deploy_gallery Task Summary
Details
deploy_gallery
Details
deploy_gallery-macos Task Summary
Details
deploy_gallery-macos
Details
docs Task Summary
Details
docs
Details
flutter-build
Details
integration_tests-linux Task Summary
Details
integration_tests-linux
Details
integration_tests-windows Task Summary
Details
integration_tests-windows
Details
integration_tests_gradle1-linux Task Summary
Details
integration_tests_gradle1-linux
Details
integration_tests_gradle1-windows Task Summary
Details
integration_tests_gradle1-windows
Details
integration_tests_gradle2-linux Task Summary
Details
integration_tests_gradle2-linux
Details
integration_tests_gradle2-windows Task Summary
Details
integration_tests_gradle2-windows
Details
release_smoke_tests Task Summary
Details
release_smoke_tests
Details
tests_extras-linux Task Summary
Details
tests_extras-linux
Details
tests_extras-windows Task Summary
Details
tests_extras-windows
Details
tests_framework_other-linux Task Summary
Details
tests_framework_other-linux
Details
tests_framework_other-windows Task Summary
Details
tests_framework_other-windows
Details
tests_widgets-linux Task Summary
Details
tests_widgets-linux
Details
tests_widgets-windows Task Summary
Details
tests_widgets-windows
Details
tool_coverage-linux
Details
tool_tests-linux
Details
tool_tests-macos
Details
tool_tests-windows
Details
tool_tests_create-linux
Details
tool_tests_create-macos
Details
tool_tests_create-windows
Details
tool_tests_integration-linux
Details
tool_tests_integration-windows
Details
web_tests-linux Task Summary
Details
web_tests-linux
Details
@cyanglaz cyanglaz deleted the cyanglaz:common_platform_view_rename branch Aug 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.