Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ToggleButtons test improvement #38898

Merged
merged 5 commits into from Sep 5, 2019

Conversation

shihaohong
Copy link
Contributor

@shihaohong shihaohong commented Aug 20, 2019

Description

This improves the ToggleButtons test files to have more precise finders looking for DefaultTextStyle and IconTheme. Instead of using the first ancestor widget looking up the tree (there will be 2+ widgets), it looks for the single descendant widget of the RawMaterialButton.

Related Issues

n/a

Tests

The modified lines improve existing tests

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I signed the CLA.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require Flutter developers to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (Please read Handling breaking changes). Replace this with a link to the e-mail where you asked for input on this proposed change.
  • No, this is not a breaking change.

@shihaohong shihaohong added framework flutter/packages/flutter repository. See also f: labels. f: material design flutter/packages/flutter/material repository. labels Aug 20, 2019
Copy link
Contributor

@HansMuller HansMuller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe just define a local function that returns a text style. Like:

TextStyle buttonTextStyle(String text) {
  return tester.widget<DefaultTextStyle>(
    find.descendant(
      of: find.widgetWithText(RawMaterialButton, text),
      matching: find.byType(DefaultTextStyle),
    )
  ).style;
}

Copy link
Contributor

@HansMuller HansMuller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shihaohong shihaohong merged commit abfc560 into flutter:master Sep 5, 2019
@shihaohong shihaohong deleted the toggle-buttons-finder branch September 5, 2019 22:12
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants