Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove a period from the service protocol printout #39545

Merged
merged 1 commit into from Aug 31, 2019

Conversation

devoncarew
Copy link
Member

Description

  • remove a period from the service protocol printout

If users include the period (when copying and pasting the url to a tool like devtools), they'll see an error when trying to connect.

@jonahwilliams

@fluttergithubbot fluttergithubbot added the tool Affects the "flutter" command-line tool. See also t: labels. label Aug 30, 2019
@fluttergithubbot
Copy link
Contributor

It looks like this pull request may not have tests. Please make sure to add tests before merging. While there are exceptions to this rule, if this patch modifies code it is probably not an exception.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Copy link
Member

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

D'oh

LGTM!

@codecov
Copy link

codecov bot commented Aug 30, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@359b532). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #39545   +/-   ##
=========================================
  Coverage          ?   56.61%           
=========================================
  Files             ?      195           
  Lines             ?    18507           
  Branches          ?        0           
=========================================
  Hits              ?    10478           
  Misses            ?     8029           
  Partials          ?        0
Flag Coverage Δ
#flutter_tool 56.61% <100%> (?)
Impacted Files Coverage Δ
...ools/lib/src/build_runner/resident_web_runner.dart 70.14% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 359b532...f221f11. Read the comment docs.

@devoncarew devoncarew merged commit e468296 into flutter:master Aug 31, 2019
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
tool Affects the "flutter" command-line tool. See also t: labels.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants