Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show outdated CocoaPods version in hint text #40117

Merged
merged 1 commit into from Sep 10, 2019

Conversation

jmagman
Copy link
Member

@jmagman jmagman commented Sep 10, 2019

Description

Was:

CocoaPods out of date (1.6.0 is recommended).

Now:

CocoaPods 1.4.0 out of date (1.6.0 is recommended).

Related Issues

Fixes #40116.

Tests

Updated CocoaPods validator test.

Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I signed the [CLA].
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

  • Yes, this is a breaking change (Please read [Handling breaking changes]). Replace this with a link to the e-mail where you asked for input on this proposed change.
  • No, this is not a breaking change.

@jmagman jmagman added tool Affects the "flutter" command-line tool. See also t: labels. t: flutter doctor Problem related to the "flutter doctor" tool labels Sep 10, 2019
@jmagman jmagman self-assigned this Sep 10, 2019
Copy link
Member

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch, lgtm

@codecov
Copy link

codecov bot commented Sep 10, 2019

Codecov Report

Merging #40117 into master will decrease coverage by 0.89%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #40117     +/-   ##
=========================================
- Coverage   58.94%   58.05%   -0.9%     
=========================================
  Files         192      194      +2     
  Lines       18442    18727    +285     
=========================================
+ Hits        10871    10872      +1     
- Misses       7571     7855    +284
Flag Coverage Δ
#flutter_tool 58.05% <100%> (-0.9%) ⬇️
Impacted Files Coverage Δ
...utter_tools/lib/src/macos/cocoapods_validator.dart 82.6% <100%> (+0.79%) ⬆️
...ages/flutter_tools/lib/src/base/user_messages.dart 49.05% <100%> (+7.54%) ⬆️
packages/flutter_tools/lib/src/base/utils.dart 81.18% <0%> (-13.37%) ⬇️
...lib/src/build_runner/web_compilation_delegate.dart 14.15% <0%> (-11.24%) ⬇️
packages/flutter_tools/lib/src/web/compile.dart 78.78% <0%> (-5.59%) ⬇️
packages/flutter_tools/lib/src/compile.dart 71.57% <0%> (-5.36%) ⬇️
packages/flutter_tools/lib/src/devfs.dart 65.51% <0%> (-2.96%) ⬇️
packages/flutter_tools/lib/src/version.dart 90.9% <0%> (-1.92%) ⬇️
...ckages/flutter_tools/lib/src/base/file_system.dart 67.85% <0%> (-1.79%) ⬇️
packages/flutter_tools/lib/src/cache.dart 43.5% <0%> (-0.73%) ⬇️
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a7c06e1...51dde26. Read the comment docs.

@jmagman jmagman merged commit 1222926 into flutter:master Sep 10, 2019
@jmagman jmagman deleted the cocoapods-version branch September 10, 2019 20:26
Inconnu08 pushed a commit to Inconnu08/flutter that referenced this pull request Sep 30, 2019
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
t: flutter doctor Problem related to the "flutter doctor" tool tool Affects the "flutter" command-line tool. See also t: labels.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

flutter doctor should output the detected CocoaPods version when it is out of date
3 participants