Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[flutter_tools] Adds tests of mdns analytics events #41410

Merged
merged 1 commit into from Sep 27, 2019
Merged

[flutter_tools] Adds tests of mdns analytics events #41410

merged 1 commit into from Sep 27, 2019

Conversation

zanderso
Copy link
Member

Description

Tests for #41384

Breaking Change

Does your PR require Flutter developers to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (Please read [Handling breaking changes]). Replace this with a link to the e-mail where you asked for input on this proposed change.
  • No, this is not a breaking change.

@zanderso zanderso added the tool Affects the "flutter" command-line tool. See also t: labels. label Sep 26, 2019
Copy link
Member

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@codecov
Copy link

codecov bot commented Sep 26, 2019

Codecov Report

Merging #41410 into master will decrease coverage by 0.68%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #41410      +/-   ##
==========================================
- Coverage   60.43%   59.75%   -0.69%     
==========================================
  Files         193      193              
  Lines       18760    18760              
==========================================
- Hits        11338    11210     -128     
- Misses       7422     7550     +128
Flag Coverage Δ
#flutter_tool 59.75% <ø> (-0.69%) ⬇️
Impacted Files Coverage Δ
packages/flutter_tools/lib/src/base/net.dart 0% <0%> (-86.96%) ⬇️
...s/flutter_tools/lib/src/macos/xcode_validator.dart 0% <0%> (-85.72%) ⬇️
...s/flutter_tools/lib/src/tester/flutter_tester.dart 28.12% <0%> (-43.75%) ⬇️
packages/flutter_tools/lib/src/bundle.dart 47.82% <0%> (-31.53%) ⬇️
packages/flutter_tools/lib/src/base/common.dart 72.72% <0%> (-18.19%) ⬇️
packages/flutter_tools/lib/src/base/context.dart 49.12% <0%> (-8.78%) ⬇️
...ages/flutter_tools/lib/src/base/user_messages.dart 45.94% <0%> (-5.41%) ⬇️
packages/flutter_tools/lib/src/base/io.dart 48.88% <0%> (-4.45%) ⬇️
packages/flutter_tools/lib/src/base/terminal.dart 77.77% <0%> (-3.71%) ⬇️
packages/flutter_tools/lib/src/version.dart 91.9% <0%> (-1.43%) ⬇️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bb7e3f6...149d276. Read the comment docs.

Copy link
Contributor

@tvolkert tvolkert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@zanderso
Copy link
Member Author

Coverage report isn't quite right for PRs that only have tests. Landing.

@zanderso zanderso merged commit 716a672 into flutter:master Sep 27, 2019
@zanderso zanderso deleted the mdns-event-test branch September 27, 2019 15:07
tvolkert pushed a commit to tvolkert/flutter that referenced this pull request Sep 27, 2019
@tvolkert tvolkert mentioned this pull request Sep 27, 2019
tvolkert added a commit that referenced this pull request Sep 27, 2019
* [flutter_tools] Report iOS mDNS lookup failures to analytics (#41384)
* [flutter_tools] Adds tests of mdns analytics events (#41410)
* [flutter_tool] Add analytics events for ios-mdns fallback success/failure (#41482)
* roll ideviceinstaller, libimobiledevice, libplist, openssl & usbmuxd to signed versions (#41411)
Inconnu08 pushed a commit to Inconnu08/flutter that referenced this pull request Sep 30, 2019
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
tool Affects the "flutter" command-line tool. See also t: labels.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants