New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[flutter_tools] Adds tests of mdns analytics events #41410
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Codecov Report
@@ Coverage Diff @@
## master #41410 +/- ##
==========================================
- Coverage 60.43% 59.75% -0.69%
==========================================
Files 193 193
Lines 18760 18760
==========================================
- Hits 11338 11210 -128
- Misses 7422 7550 +128
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks.
Coverage report isn't quite right for PRs that only have tests. Landing. |
* [flutter_tools] Report iOS mDNS lookup failures to analytics (#41384) * [flutter_tools] Adds tests of mdns analytics events (#41410) * [flutter_tool] Add analytics events for ios-mdns fallback success/failure (#41482) * roll ideviceinstaller, libimobiledevice, libplist, openssl & usbmuxd to signed versions (#41411)
Description
Tests for #41384
Breaking Change
Does your PR require Flutter developers to manually update their apps to accommodate your change?