Address previous comments, fix Intent.doNothing. #41417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fluttergithubbot
added
the
framework
gspencergoog
force-pushed
the
find_dispatcher
branch
from
5fa3420
to
ebbcc3c
Compare
darrenaustin
approved these changes
Sep 26, 2019
gspencergoog
added a commit
to gspencergoog/flutter
that referenced
this pull request
Sep 27, 2019
…)" This reverts commit eb3e2f5 because of a suspected analyzer bug. Reverting to investigate.
gspencergoog
added a commit
that referenced
this pull request
Sep 27, 2019
gspencergoog
added a commit
to gspencergoog/flutter
that referenced
this pull request
Sep 27, 2019
…tter#41417)" (flutter#41449)" This reverts commit 957d839.
1 task
gspencergoog
added a commit
that referenced
this pull request
Sep 28, 2019
This re-lands #41417 with a slight change that will hopefully not tickle the analyzer as it did before. The last time I tried to land this, the analyzer succeeded for the analyze step in Cirrus, and locally, but failed in an integration test.
Inconnu08
pushed a commit
to Inconnu08/flutter
that referenced
this pull request
Sep 30, 2019
This addresses comments in the original PR (flutter#41245) that introduced Intent.doNothing, adds tests, and fixes an issue with it.
Inconnu08
pushed a commit
to Inconnu08/flutter
that referenced
this pull request
Sep 30, 2019
…)" (flutter#41449) This reverts commit eb3e2f5 because of a suspected analyzer bug. Reverting to investigate.
Inconnu08
pushed a commit
to Inconnu08/flutter
that referenced
this pull request
Sep 30, 2019
…1477) This re-lands flutter#41417 with a slight change that will hopefully not tickle the analyzer as it did before. The last time I tried to land this, the analyzer succeeded for the analyze step in Cirrus, and locally, but failed in an integration test.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This addresses comments in the original PR (#41245) that introduced
Intent.doNothing, adds tests, and fixes an issue with it.Related Issues
Tests
Intent.doNothing.Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change
Does your PR require Flutter developers to manually update their apps to accommodate your change?