Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch build commands to use process utils #42373

Merged
merged 1 commit into from Oct 10, 2019

Conversation

jonahwilliams
Copy link
Member

Description

This is just a higher level wrapper around the same code we are calling. No tests are effected because we are still correctly mocking/asserting the lower level and behavior is unchanged.

Fixes #42261

@fluttergithubbot
Copy link
Contributor

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@fluttergithubbot fluttergithubbot added the tool Affects the "flutter" command-line tool. See also t: labels. label Oct 9, 2019
Copy link
Member

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@codecov
Copy link

codecov bot commented Oct 10, 2019

Codecov Report

Merging #42373 into master will decrease coverage by 0.46%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #42373      +/-   ##
==========================================
- Coverage   60.28%   59.81%   -0.47%     
==========================================
  Files         194      194              
  Lines       18868    18962      +94     
==========================================
- Hits        11374    11343      -31     
- Misses       7494     7619     +125
Flag Coverage Δ
#flutter_tool 59.81% <100%> (-0.47%) ⬇️
Impacted Files Coverage Δ
...s/flutter_tools/lib/src/windows/build_windows.dart 81.25% <100%> (-4.12%) ⬇️
...kages/flutter_tools/lib/src/macos/build_macos.dart 90% <100%> (-2.31%) ⬇️
...kages/flutter_tools/lib/src/linux/build_linux.dart 83.87% <100%> (-3.63%) ⬇️
...utter_tools/lib/src/macos/cocoapods_validator.dart 47.82% <0%> (-34.79%) ⬇️
...ckages/flutter_tools/lib/src/platform_plugins.dart 49.5% <0%> (-28.72%) ⬇️
...ages/flutter_tools/lib/src/linux/linux_device.dart 44.44% <0%> (-26.99%) ⬇️
packages/flutter_tools/lib/src/dart/sdk.dart 80% <0%> (-20%) ⬇️
packages/flutter_tools/lib/src/features.dart 83.33% <0%> (-14.23%) ⬇️
packages/flutter_tools/lib/src/base/io.dart 53.33% <0%> (-11.54%) ⬇️
packages/flutter_tools/lib/src/ios/devices.dart 65.97% <0%> (-9.33%) ⬇️
... and 38 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8fcc1d4...7a4d72d. Read the comment docs.

@jonahwilliams jonahwilliams merged commit 4803428 into flutter:master Oct 10, 2019
@jonahwilliams jonahwilliams deleted the use_process_utils branch October 10, 2019 01:58
Inconnu08 pushed a commit to Inconnu08/flutter that referenced this pull request Nov 26, 2019
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
tool Affects the "flutter" command-line tool. See also t: labels.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tool Cleanup: replace processManager.start with processUtils.stream
5 participants