Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Pad CupertinoAlertDialog with MediaQuery viewInsets #42967
This PR makes
I intend to add the following tests:
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
Does your PR require Flutter developers to manually update their apps to accommodate your change?
Hey @justinmc, I got this working but having trouble writing tests. It seems the dialog has an alignment somewhere that messes with its final position.
Is there a way to debug a widget test? Like can I inspect the widget tree or see the widgets rendered?
There is no way to view the widgets that a test is pumping (as far as I know). What I usually do is just copy the code into an empty app and manually go through the steps that the test does. You can also put print statements in the Flutter source code and they will be output with the test output.
Two not so nice solutions haha, but hopefully that helps. I can also take a closer look tomorrow.
justinmc left a comment
Quick comment below about deduplicating docs. Otherwise I think this looks great. I confirmed that the test covers the problem and fails on master. Let me know about the docs thing and I'll approve and then this can be merged!