Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-Land: Add focus nodes, hover, and shortcuts to switches, checkboxes, and radio buttons. #43384

Merged
merged 2 commits into from Oct 28, 2019

Conversation

@gspencergoog
Copy link
Contributor

gspencergoog commented Oct 23, 2019

Description

This re-lands the change that adds focus nodes, hover, and shortcuts to switches, checkboxes, and radio buttons. (#43213)

No changes from original, except for finding the right RenderBox in dev/integration_tests/android_semantics_testing/test_driver/main_test.dart.

Breaking Change

  • No, this is not a breaking change.
…eckboxes, and radio buttons. (#43213)" (#43367)"

This reverts commit ed36fe5.
Copy link
Contributor

darrenaustin left a comment

There's a lot here, and I might have missed something, but this LGTM.

return getSemantics(
find.descendant(
of: find.byValueKey(key),
matching: find.byType('_CheckboxRenderObjectWidget'),

This comment has been minimized.

Copy link
@darrenaustin

darrenaustin Oct 25, 2019

Contributor

Why does this need to be against _CheckboxRenderObjectWidget and not just the key?

This comment has been minimized.

Copy link
@gspencergoog

gspencergoog Oct 25, 2019

Author Contributor

Because the key corresponds to a RenderMouseRegion now that I've added the MouseRegion, so we have to dig down to find the render object for the checkbox which adds the semantics.

@@ -67,11 +67,12 @@ void main() {
),
));

expect(tester.getSemantics(find.byType(Checkbox)), matchesSemantics(
expect(tester.getSemantics(find.byType(Focus)), matchesSemantics(

This comment has been minimized.

Copy link
@darrenaustin

darrenaustin Oct 25, 2019

Contributor

Why the change from Checkbox to Focus here?

This comment has been minimized.

Copy link
@gspencergoog

gspencergoog Oct 25, 2019

Author Contributor

Because that gets us down past the RenderMouseRegion so that it gets the _CheckboxRenderObjectWidget render object to query semantics from. Since Focus doesn't have a render object associated with it, it defers to the _CheckboxRenderObjectWidget.

@gspencergoog gspencergoog merged commit 8017f63 into flutter:master Oct 28, 2019
99 of 100 checks passed
99 of 100 checks passed
flutter-build Flutter build is currently broken. Please do not merge this PR unless it contains a fix to the broken build.
Details
add_to_app_tests-macos Task Summary
Details
WIP Ready for review
Details
add_to_app_tests-macos
Details
analyze-linux Task Summary
Details
analyze-linux
Details
build_tests-linux Task Summary
Details
build_tests-linux
Details
build_tests-macos Task Summary
Details
build_tests-macos
Details
build_tests-windows Task Summary
Details
build_tests-windows
Details
cla/google All necessary CLAs are signed
customer_testing-linux Task Summary
Details
customer_testing-linux
Details
customer_testing-macos Task Summary
Details
customer_testing-macos
Details
customer_testing-windows Task Summary
Details
customer_testing-windows
Details
deploy_gallery-linux Task Summary
Details
deploy_gallery-linux
Details
deploy_gallery-macos Task Summary
Details
deploy_gallery-macos
Details
docs-linux Task Summary
Details
docs-linux
Details
firebase_test_lab_tests-linux Task Summary
Details
firebase_test_lab_tests-linux
Details
framework_tests-libraries-linux Task Summary
Details
framework_tests-libraries-linux
Details
framework_tests-libraries-macos Task Summary
Details
framework_tests-libraries-macos
Details
framework_tests-libraries-windows Task Summary
Details
framework_tests-libraries-windows
Details
framework_tests-misc-linux Task Summary
Details
framework_tests-misc-linux
Details
framework_tests-misc-macos Task Summary
Details
framework_tests-misc-macos
Details
framework_tests-misc-windows Task Summary
Details
framework_tests-misc-windows
Details
framework_tests-widgets-linux Task Summary
Details
framework_tests-widgets-linux
Details
framework_tests-widgets-macos Task Summary
Details
framework_tests-widgets-macos
Details
framework_tests-widgets-windows Task Summary
Details
framework_tests-widgets-windows
Details
hostonly_devicelab_tests-0-linux Task Summary
Details
hostonly_devicelab_tests-0-linux
Details
hostonly_devicelab_tests-0-macos Task Summary
Details
hostonly_devicelab_tests-0-macos
Details
hostonly_devicelab_tests-0-windows Task Summary
Details
hostonly_devicelab_tests-0-windows
Details
hostonly_devicelab_tests-1-linux Task Summary
Details
hostonly_devicelab_tests-1-linux
Details
hostonly_devicelab_tests-1-macos Task Summary
Details
hostonly_devicelab_tests-1-macos
Details
hostonly_devicelab_tests-1-windows Task Summary
Details
hostonly_devicelab_tests-1-windows
Details
hostonly_devicelab_tests-2-linux Task Summary
Details
hostonly_devicelab_tests-2-linux
Details
hostonly_devicelab_tests-2-macos Task Summary
Details
hostonly_devicelab_tests-2-macos
Details
hostonly_devicelab_tests-2-windows Task Summary
Details
hostonly_devicelab_tests-2-windows
Details
hostonly_devicelab_tests-3-linux Task Summary
Details
hostonly_devicelab_tests-3-linux
Details
hostonly_devicelab_tests-3-macos Task Summary
Details
hostonly_devicelab_tests-3-macos
Details
hostonly_devicelab_tests-3-windows Task Summary
Details
hostonly_devicelab_tests-3-windows
Details
hostonly_devicelab_tests-4-linux Task Summary
Details
hostonly_devicelab_tests-4-linux
Details
hostonly_devicelab_tests-4-macos Task Summary
Details
hostonly_devicelab_tests-4-macos
Details
hostonly_devicelab_tests-4-windows Task Summary
Details
hostonly_devicelab_tests-4-windows
Details
hostonly_devicelab_tests-5_last-linux Task Summary
Details
hostonly_devicelab_tests-5_last-linux
Details
hostonly_devicelab_tests-5_last-macos Task Summary
Details
hostonly_devicelab_tests-5_last-macos
Details
hostonly_devicelab_tests-5_last-windows Task Summary
Details
hostonly_devicelab_tests-5_last-windows
Details
tool_tests-commands-linux Task Summary
Details
tool_tests-commands-linux
Details
tool_tests-commands-macos Task Summary
Details
tool_tests-commands-macos
Details
tool_tests-commands-windows Task Summary
Details
tool_tests-commands-windows
Details
tool_tests-general-linux Task Summary
Details
tool_tests-general-linux
Details
tool_tests-general-macos Task Summary
Details
tool_tests-general-macos
Details
tool_tests-general-windows Task Summary
Details
tool_tests-general-windows
Details
tool_tests-integration-linux Task Summary
Details
tool_tests-integration-linux
Details
tool_tests-integration-macos Task Summary
Details
tool_tests-integration-macos
Details
tool_tests-integration-windows Task Summary
Details
tool_tests-integration-windows
Details
web_tests-0-linux Task Summary
Details
@yjbanov

This comment has been minimized.

Copy link
Contributor

yjbanov commented Oct 28, 2019

This PR seems to have broken web tests on master.

gspencergoog added a commit to gspencergoog/flutter that referenced this pull request Oct 28, 2019
…heckboxes, and radio buttons. (flutter#43384)"

This reverts commit 8017f63, since it breaks web tests.
gspencergoog added a commit that referenced this pull request Oct 28, 2019
…heckboxes, and radio buttons. (#43384)" (#43647)

This reverts commit 8017f63, since it breaks web tests.
gspencergoog added a commit to gspencergoog/flutter that referenced this pull request Oct 28, 2019
…s, and radio buttons. (flutter#43384)

This reverts commit 04071ec to reapply focus changes.
gspencergoog added a commit to gspencergoog/flutter that referenced this pull request Oct 28, 2019
…s, and radio buttons. (flutter#43384)

This reverts commit 38f2d27 to fix web tests.
gspencergoog added a commit to gspencergoog/flutter that referenced this pull request Oct 28, 2019
…s, and radio buttons. (flutter#43384)

This reverts commit 38f2d27 to fix web tests.
gspencergoog added a commit to gspencergoog/flutter that referenced this pull request Oct 29, 2019
…s, and radio buttons. (flutter#43384)

This reverts commit 38f2d27 to fix web tests.
gspencergoog added a commit to gspencergoog/flutter that referenced this pull request Oct 29, 2019
…s, and radio buttons. (flutter#43384)

This reverts commit 38f2d27 to fix web tests.
gspencergoog added a commit to gspencergoog/flutter that referenced this pull request Oct 30, 2019
…s, and radio buttons. (flutter#43384)

This reverts commit 38f2d27 to fix web tests.
gspencergoog added a commit to gspencergoog/flutter that referenced this pull request Nov 1, 2019
…s, and radio buttons. (flutter#43384)

This reverts commit 38f2d27 to fix web tests.
gspencergoog added a commit to gspencergoog/flutter that referenced this pull request Nov 1, 2019
…s, and radio buttons. (flutter#43384)

This reverts commit 38f2d27 to fix web tests.
sahandevs added a commit to sahandevs/flutter that referenced this pull request Nov 15, 2019
…s, and radio buttons. (flutter#43384)

This re-lands the change that adds focus nodes, hover, and shortcuts to switches, checkboxes, and radio buttons. (flutter#43213)

No changes from original, except for finding the right RenderBox in dev/integration_tests/android_semantics_testing/test_driver/main_test.dart.
sahandevs added a commit to sahandevs/flutter that referenced this pull request Nov 15, 2019
…heckboxes, and radio buttons. (flutter#43384)" (flutter#43647)

This reverts commit 8017f63, since it breaks web tests.
sahandevs added a commit to sahandevs/flutter that referenced this pull request Nov 15, 2019
…s, and radio buttons. (flutter#43384)

This re-lands the change that adds focus nodes, hover, and shortcuts to switches, checkboxes, and radio buttons. (flutter#43213)

No changes from original, except for finding the right RenderBox in dev/integration_tests/android_semantics_testing/test_driver/main_test.dart.
sahandevs added a commit to sahandevs/flutter that referenced this pull request Nov 15, 2019
…heckboxes, and radio buttons. (flutter#43384)" (flutter#43647)

This reverts commit 8017f63, since it breaks web tests.
sahandevs added a commit to sahandevs/flutter that referenced this pull request Nov 15, 2019
…tches, checkboxes, and radio buttons. (flutter#43384)" (flutter#43647)"

This reverts commit e6d9009.
sahandevs added a commit to sahandevs/flutter that referenced this pull request Nov 15, 2019
Inconnu08 added a commit to Inconnu08/flutter that referenced this pull request Nov 26, 2019
…s, and radio buttons. (flutter#43384)

This re-lands the change that adds focus nodes, hover, and shortcuts to switches, checkboxes, and radio buttons. (flutter#43213)

No changes from original, except for finding the right RenderBox in dev/integration_tests/android_semantics_testing/test_driver/main_test.dart.
Inconnu08 added a commit to Inconnu08/flutter that referenced this pull request Nov 26, 2019
…heckboxes, and radio buttons. (flutter#43384)" (flutter#43647)

This reverts commit 8017f63, since it breaks web tests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.