mark widget == and hashCode as nonVirtual #46900
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fluttergithubbot
added
the
framework
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie. Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
There's no judgement required to establish if something is a breaking change anymore. It's entirely based on whether any tests fail. See https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes for details. |
|
@pq Is this PR ready to be submitted? |
|
Sorry, yes. Thanks! Let's land when the build is green again. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Mark Widget
==andhashCodeas@nonVirtual, effectively disallowing unwanted overrides.In conversation, @Hixie raised a question of performance; @mraleph: can you speak to how negligible (or not) the impact of these redirects would be?
I'm also not sure if this constitutes a breaking change. (I'm thinking not?)
Related Issues
#1220
#41220 (comment)
dart-lang/linter#1783
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change
Did any tests fail when you ran them? Please read Handling breaking changes.