[flutter_tools] fix path escaping on in depfile generation #50538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fluttergithubbot
added
the
tool
zanderso
reviewed
Feb 11, 2020
| final String escapedPath = outputFile.path.replaceAll(r'\', r'\\'); | ||
| final String escapedPath = outputFile.path | ||
| .replaceAll(r'\', r'\\') | ||
| .replaceAll(r' ', r'\ '); | ||
| buffer.write(' $escapedPath'); | ||
| } else { | ||
| buffer.write(' ${outputFile.path}'); |
There was a problem hiding this comment.
Does _separatorExpr imply that spaces have to be escaped on all platforms? That is, a space preceded by anything but a '' is a separator not just on Windows, but on other platforms as well.
| expect(outputDepfile.readAsStringSync(), contains(r'C:\\Hello\ Flutter\\b.txt')); | ||
| }, overrides: <Type, Generator>{ | ||
| FileSystem: () => MemoryFileSystem(style: FileSystemStyle.windows), | ||
| Platform: () => FakePlatform(operatingSystem: 'windows'), |
There was a problem hiding this comment.
Test spaces in paths on other platforms, too.
jonahwilliams
changed the title
|
I double checked, and you're right - they have to be escaped on macOS/Linux too. Updating PR. 🤦♂ |
zanderso
approved these changes
Feb 11, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When a depfile is generated for gradle build, empty spaces
#16604