Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reland "Fix RefreshIndicator performance issue" #53206

Merged

Conversation

dnfield
Copy link
Contributor

@dnfield dnfield commented Mar 24, 2020

Reverts #53149

Relands #47667

Fixes #47664 (again)

Internal cl/302771967 fixed the failing test for this.

/cc @LongCatIsLooong @christian-muertz

@fluttergithubbot fluttergithubbot added f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels Mar 24, 2020
Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fluttergithubbot fluttergithubbot merged commit 25ef78e into master Mar 25, 2020
@dnfield dnfield deleted the revert-53149-revert-47667-refresh_indicator_perf branch March 25, 2020 16:39
gnawf added a commit to gnawf/microcosm that referenced this pull request Apr 8, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RefreshIndicator is expensive
4 participants