[flutter_tool] Timeout the Azure bot detector http request #53217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zanderso
added
tool
| return completer.future; // Never completed to test timeout behavior. | ||
| }); | ||
|
|
||
| unawaited(azureDetector.isRunningOnAzure.then((bool onBot) { |
There was a problem hiding this comment.
The structure of this test is a little odd, because it seems like this expectation isn't guaranteed to be hit before the test body finishes. I would rearrange it a bit, maybe something like this?
FakeAsync().run((FakeAsync time) async {
...
final Future<bool> isRunningOnAzure = azureDetector.isRunningOnAzure;
time.elapse(const Duration(seconds: 2));
expect(await isRunningOnAzure, true);
});
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When not on Azure, depending on the environment, the connection setup might not timeout, but the http request will. This PR adds a timeout for this case.
Related Issues
#53098
Tests
I added the following tests:
Added test to bot_detector_test.dart
Breaking Change
Did any tests fail when you ran them? Please read [Handling breaking changes].