Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "[flutter_tools] always initialize the resident runner from dill #58607

Merged
merged 1 commit into from Jun 3, 2020
Merged

Revert "[flutter_tools] always initialize the resident runner from dill #58607

merged 1 commit into from Jun 3, 2020

Conversation

jonahwilliams
Copy link
Member

@jonahwilliams jonahwilliams commented Jun 3, 2020 •
edited

…ll (#52497)" (#58193)

Description

Revert commit and apply changes to candidate. Only minor diffs caused by later addition of source code generation

@fluttergithubbot fluttergithubbot changed the base branch from flutter-1.17-candidate.3 to master June 3, 2020 16:28
@fluttergithubbot
Copy link
Contributor

This pull request was opened against a branch other than master. Since Flutter pull requests should not normally be opened against branches other than master, I have changed the base to master. If this was intended, you may modify the base back to flutter-1.17-candidate.3. See the Release Process for information about how other branches get updated.

Reviewers: Use caution before merging pull requests to branches other than master, unless this is an intentional hotfix/cherrypick.

@jonahwilliams jonahwilliams changed the base branch from master to flutter-1.17-candidate.3 June 3, 2020 16:29
@fluttergithubbot fluttergithubbot added tool Affects the "flutter" command-line tool. See also t: labels. a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) d: examples Sample code and demos engine flutter/engine repository. See also e: labels. f: cupertino flutter/packages/flutter/cupertino repository f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. team Infra upgrades, team productivity, code health, technical debt. See also team: labels. labels Jun 3, 2020
@pcsosinski
Copy link

LGTM for branch submission (thanks!) fuchsia_precache-linux failure is not a concern here.

@jonahwilliams jonahwilliams merged commit 1122d84 into flutter:flutter-1.17-candidate.3 Jun 3, 2020
@jonahwilliams jonahwilliams deleted the flutter-1.17-candidate.3 branch June 3, 2020 19:39
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 31, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@zanderso zanderso zanderso approved these changes

@pcsosinski pcsosinski Awaiting requested review from pcsosinski

Assignees
No one assigned
Labels
a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) d: examples Sample code and demos engine flutter/engine repository. See also e: labels. f: cupertino flutter/packages/flutter/cupertino repository f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. team Infra upgrades, team productivity, code health, technical debt. See also team: labels. tool Affects the "flutter" command-line tool. See also t: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@jonahwilliams @fluttergithubbot @pcsosinski @zanderso @googlebot