Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

restore imagefiltered_transform_animation_perf__timeline_summary benchmark #60415

Merged
merged 1 commit into from Jun 27, 2020

Conversation

flar
Copy link
Contributor

@flar flar commented Jun 27, 2020

When the Heavey Widget Construction and Destruction benchmark was added, the button to run the ImageFiltered Transform Animation benchmark was accidentally deleted. This PR will restore the button so the benchmark can run.

@flar flar requested a review from liyuqian June 27, 2020 06:42
@fluttergithubbot
Copy link
Contributor

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@fluttergithubbot fluttergithubbot added the team Infra upgrades, team productivity, code health, technical debt. See also team: labels. label Jun 27, 2020
@godofredoc godofredoc self-requested a review June 27, 2020 06:51
Copy link
Contributor

@godofredoc godofredoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

@flutter-github-sync
Copy link

Started Google testing for this PR

@flutter-github-sync
Copy link

Google testing passed!

@flar
Copy link
Contributor Author

flar commented Jun 27, 2020

Merging on red to fix the tree...

@flar flar merged commit 2962912 into flutter:master Jun 27, 2020
@flar
Copy link
Contributor Author

flar commented Jun 27, 2020

TBR @liyuqian

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
team Infra upgrades, team productivity, code health, technical debt. See also team: labels.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants