Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Add support for Dart Development Service (DDS) in Flutter Tools" #61276

Merged
merged 1 commit into from Jul 10, 2020

Conversation

dnfield
Copy link
Contributor

@dnfield dnfield commented Jul 10, 2020

Reverts #59114

TBR @bkonyi @jonahwilliams @zanderso

Broke the devicealb

@fluttergithubbot fluttergithubbot added team Infra upgrades, team productivity, code health, technical debt. See also team: labels. tool Affects the "flutter" command-line tool. See also t: labels. labels Jul 10, 2020
@dnfield dnfield merged commit 5b9c6e2 into master Jul 10, 2020
@dnfield dnfield deleted the revert-59114-dds_integration_take_2 branch July 10, 2020 22:53
@jonahwilliams
Copy link
Member

LGTM, thanks Dan!

bkonyi added a commit that referenced this pull request Jul 13, 2020
bkonyi added a commit that referenced this pull request Jul 14, 2020
bkonyi added a commit that referenced this pull request Jul 14, 2020
bkonyi added a commit that referenced this pull request Jul 14, 2020
bkonyi added a commit that referenced this pull request Jul 16, 2020
bkonyi added a commit that referenced this pull request Jul 16, 2020
bkonyi added a commit that referenced this pull request Jul 16, 2020
bkonyi added a commit that referenced this pull request Jul 16, 2020
bkonyi added a commit that referenced this pull request Jul 20, 2020
bkonyi added a commit that referenced this pull request Jul 20, 2020
bkonyi added a commit that referenced this pull request Jul 20, 2020
bkonyi added a commit that referenced this pull request Jul 20, 2020
bkonyi added a commit that referenced this pull request Jul 21, 2020
bkonyi added a commit that referenced this pull request Jul 21, 2020
bkonyi added a commit that referenced this pull request Jul 21, 2020
bkonyi added a commit that referenced this pull request Jul 21, 2020
bkonyi added a commit that referenced this pull request Jul 23, 2020
bkonyi added a commit that referenced this pull request Jul 29, 2020
bkonyi added a commit that referenced this pull request Jul 29, 2020
…ls (#61276)" (#62147)

This reverts commit adc9dde.

- Fixed issue where `FallbackDiscovery` would hold on to a `VmService` when launching on iOS devices, causing DDS to fail to start
- Fixed `flutter drive` case where DDS is already running in another flutter_tools instance
Pragya007 pushed a commit to Pragya007/flutter that referenced this pull request Aug 11, 2020
Pragya007 pushed a commit to Pragya007/flutter that referenced this pull request Aug 11, 2020
Pragya007 pushed a commit to Pragya007/flutter that referenced this pull request Aug 11, 2020
Pragya007 pushed a commit to Pragya007/flutter that referenced this pull request Aug 11, 2020
Pragya007 pushed a commit to Pragya007/flutter that referenced this pull request Aug 11, 2020
Pragya007 pushed a commit to Pragya007/flutter that referenced this pull request Aug 11, 2020
Pragya007 pushed a commit to Pragya007/flutter that referenced this pull request Aug 11, 2020
Pragya007 pushed a commit to Pragya007/flutter that referenced this pull request Aug 11, 2020
Pragya007 pushed a commit to Pragya007/flutter that referenced this pull request Aug 11, 2020
…ls (flutter#61276)" (flutter#62147)

This reverts commit adc9dde.

- Fixed issue where `FallbackDiscovery` would hold on to a `VmService` when launching on iOS devices, causing DDS to fail to start
- Fixed `flutter drive` case where DDS is already running in another flutter_tools instance
mingwandroid pushed a commit to mingwandroid/flutter that referenced this pull request Sep 6, 2020
mingwandroid pushed a commit to mingwandroid/flutter that referenced this pull request Sep 6, 2020
mingwandroid pushed a commit to mingwandroid/flutter that referenced this pull request Sep 6, 2020
mingwandroid pushed a commit to mingwandroid/flutter that referenced this pull request Sep 6, 2020
mingwandroid pushed a commit to mingwandroid/flutter that referenced this pull request Sep 6, 2020
mingwandroid pushed a commit to mingwandroid/flutter that referenced this pull request Sep 6, 2020
mingwandroid pushed a commit to mingwandroid/flutter that referenced this pull request Sep 6, 2020
mingwandroid pushed a commit to mingwandroid/flutter that referenced this pull request Sep 6, 2020
mingwandroid pushed a commit to mingwandroid/flutter that referenced this pull request Sep 6, 2020
mingwandroid pushed a commit to mingwandroid/flutter that referenced this pull request Sep 6, 2020
…ls (flutter#61276)" (flutter#62147)

This reverts commit adc9dde.

- Fixed issue where `FallbackDiscovery` would hold on to a `VmService` when launching on iOS devices, causing DDS to fail to start
- Fixed `flutter drive` case where DDS is already running in another flutter_tools instance
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
team Infra upgrades, team productivity, code health, technical debt. See also team: labels. tool Affects the "flutter" command-line tool. See also t: labels.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants