issue 61346 route can be added and disposed in the same frame #61375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fluttergithubbot
added
the
framework
goderbauer
reviewed
Jul 13, 2020
| try { | ||
| controller.index = 2; | ||
| await tester.pumpAndSettle(); | ||
| } catch (e){ |
| } | ||
|
|
||
| expect(error, isNull); | ||
|
|
There was a problem hiding this comment.
nit: remove extra blank line
| error = e; | ||
| } | ||
|
|
||
| expect(error, isNull); |
There was a problem hiding this comment.
Do you need this? Wouldn't the test fail by itself if it throws an error?
HansMuller
reviewed
Jul 13, 2020
| @@ -213,7 +213,11 @@ abstract class Route<T> { | |||
| // focused child can only be attached to navigator after initState which | |||
| // will be guarded by the asynchronous gap. | |||
| TickerFuture.complete().then<void>((void _) { | |||
| navigator.focusScopeNode.requestFocus(); | |||
| // The route can be disposed before the ticker future completes. This can | |||
| // happen when the navigator is under a TabView that does a warping. The | |||
There was a problem hiding this comment.
does a warping => "warps" from one tab to another, non-adjacent tab, with an animation.
On the face of it, it's not clear why this route might have been disposed as a consequence of the warp. The test appears to set up a situation where the old Navigator will have been disposed - not its route. Can you explain this scenario in a little more detail?
Pragya007
pushed a commit
to Pragya007/flutter
that referenced
this pull request
Aug 11, 2020
mingwandroid
pushed a commit
to mingwandroid/flutter
that referenced
this pull request
Sep 6, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The route may be added and disposed in the same frame and it throws error in such cases. This pr fixes it.
Related Issues
Fixes #61346
Tests
I added the following tests:
see files
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change
Did any tests fail when you ran them? Please read Handling breaking changes.