Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[flutter_tools] turn down flutter generate #61475

Merged
merged 2 commits into from Jul 16, 2020

Conversation

jonahwilliams
Copy link
Member

@jonahwilliams jonahwilliams commented Jul 14, 2020

Description

complete removal of all generate functionality

Fixes #61508

@fluttergithubbot fluttergithubbot added tool Affects the "flutter" command-line tool. See also t: labels. work in progress; do not review labels Jul 14, 2020
@christopherfujino
Copy link
Member

The code change looks good to me. Can we delete this command in one commit, though? I'm thinking of both of internal implementations and external users using the command in their workflow.

@jonahwilliams
Copy link
Member Author

There should be no google3 implications as it is unused. I did land the deprecation earlier #58328 which should be in the next stable

Copy link
Member

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jonahwilliams jonahwilliams merged commit 045f3a5 into flutter:master Jul 16, 2020
@jonahwilliams jonahwilliams deleted the remove_flutter_generate branch July 16, 2020 16:51
Pragya007 pushed a commit to Pragya007/flutter that referenced this pull request Aug 11, 2020
complete removal of all generate functionality

Fixes flutter#61508
mingwandroid pushed a commit to mingwandroid/flutter that referenced this pull request Sep 6, 2020
complete removal of all generate functionality

Fixes flutter#61508
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
tool Affects the "flutter" command-line tool. See also t: labels.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecate and remove flutter generate functionality
4 participants