Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate framework tests for rendering, semantics, widgets to null safety #67453

Merged
merged 2 commits into from Oct 7, 2020
Merged

Migrate framework tests for rendering, semantics, widgets to null safety #67453

merged 2 commits into from Oct 7, 2020

Conversation

darrenaustin
Copy link
Contributor

Description

Another block of framework tests migrated to NNDB.

@flutter-dashboard flutter-dashboard bot added a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) framework flutter/packages/flutter repository. See also f: labels. labels Oct 6, 2020
goderbauer
goderbauer approved these changes Oct 6, 2020
View reviewed changes
Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

packages/flutter/test/rendering/viewport_test.dart Outdated Show resolved Hide resolved
packages/flutter/test/semantics/semantics_test.dart Outdated
@@ -90,7 +87,7 @@ void main() {
);

{
FlutterError error;
FlutterError? error;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could be late

packages/flutter/test/semantics/semantics_test.dart Outdated Show resolved Hide resolved
packages/flutter/test/widgets/animated_list_test.dart Outdated Show resolved Hide resolved
@darrenaustin darrenaustin merged commit af0c7ae into flutter:master Oct 7, 2020
@darrenaustin darrenaustin deleted the nndb_framework_2 branch October 7, 2020 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@goderbauer goderbauer goderbauer approved these changes

@gspencergoog gspencergoog gspencergoog approved these changes

Assignees
No one assigned
Labels
a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@darrenaustin @goderbauer @gspencergoog @googlebot