Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Builder API doc #68151

Merged
merged 3 commits into from Oct 15, 2020

Conversation

HansMuller
Copy link
Contributor

@HansMuller HansMuller commented Oct 14, 2020

Removes "platonic" from the widget class's API doc and includes a ScaffoldState.of() example.

Fixes #48137.

Thanks to Reuben Turner for taking a shot at improving this doc - #63584.

@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@flutter-dashboard flutter-dashboard bot added the framework flutter/packages/flutter repository. See also f: labels. label Oct 14, 2020
@google-cla google-cla bot added the cla: yes label Oct 14, 2020
Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

///
/// Could equally well be defined and used like this, without
/// definining a new widget class:
/// ```dart
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: space above this line?

///
/// {@youtube 560 315 https://www.youtube.com/watch?v=xXNOkIuSYuA}
///
/// This widget is a simple inline alternative to defining a StatelessWidget
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

StatelessWidget -> [StatelessWidget]

///
/// The difference between either of the previous examples and simply
/// creating a child directly, without an intervening widget, is the
/// extra BuildContext element that the additional widget adds. This
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[BuildContext]

@fluttergithubbot fluttergithubbot merged commit bf6460f into flutter:master Oct 15, 2020
@HansMuller HansMuller deleted the update_builder_api_doc branch October 15, 2020 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The use of term "platonic" is confusing
4 participants