New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated Builder API doc #68151
Updated Builder API doc #68151
Conversation
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat. Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/// | ||
/// Could equally well be defined and used like this, without | ||
/// definining a new widget class: | ||
/// ```dart |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: space above this line?
/// | ||
/// {@youtube 560 315 https://www.youtube.com/watch?v=xXNOkIuSYuA} | ||
/// | ||
/// This widget is a simple inline alternative to defining a StatelessWidget |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
StatelessWidget -> [StatelessWidget]
/// | ||
/// The difference between either of the previous examples and simply | ||
/// creating a child directly, without an intervening widget, is the | ||
/// extra BuildContext element that the additional widget adds. This |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[BuildContext]
Removes "platonic" from the widget class's API doc and includes a
ScaffoldState.of()
example.Fixes #48137.
Thanks to Reuben Turner for taking a shot at improving this doc - #63584.