Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate last batch of tests #68163

Merged
merged 1 commit into from Oct 15, 2020
Merged

Conversation

goderbauer
Copy link
Member

No description provided.

@flutter-dashboard flutter-dashboard bot added the framework flutter/packages/flutter repository. See also f: labels. label Oct 15, 2020
@google-cla google-cla bot added the cla: yes label Oct 15, 2020
Copy link
Contributor

@gspencergoog gspencergoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

32384589-a60f0e74-c078-11e7-9bc1-e5b5287aea9d

expect(location.file, equals(file));
// ClockText widget.
expect(location.line, equals(55));
expect(location.line, equals(53));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did these change?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are referring to code lines within the test file itself and since I removed two lines at the top of the file, the line numbers changed.

@fluttergithubbot fluttergithubbot merged commit aaaf374 into flutter:master Oct 15, 2020
@goderbauer goderbauer deleted the lastBatch branch November 11, 2020 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants