Remove the defaults for textBaseline

[Hixie]

We can't know what the correct default is. It depends entirely on the application's locale.

cc @tvolkert @ramnavan

Reverts #60586, #61425. See also #58053.

[ramnavan]

instead of throwing in the test and catching, could we make use of expect and throwsA methods are mentioned here and here

[Hixie]

I couldn't figure out how to make throwsA verify the text of the exception. Can you elaborate on what you'd like it to look like?

[goderbauer]

You can use .having for that:

flutter/packages/flutter/test/foundation/diagnostics_test.dart

Lines 903 to 910 in 2783f8e

	expect(
	() => describeEnum('Hello World'),
	throwsA(isAssertionError.having(
	(AssertionError e) => e.message,
	'message',
	'The provided object "Hello World" is not an enum.'),
	),
	);

[Hixie]

Thanks!

(this is why my ideal test framework has no expect and no matchers. Just use regular Dart. No need to learn crazy APIs when regular code can do the same thing in fewer lines of code, no shame in not knowing the random test library APIs. :-P)

[ramnavan]

@Hixie - changes makes sense to me. added a minor suggestion to the test.

[goderbauer]

LGTM

[Hixie]

applied suggested fix, will land on green

[fluttergithubbot]

This pull request is not suitable for automatic merging in its current state.

• The status or check suite Linux web_tests has failed. Please fix the issues identified (or deflake) before re-applying this label.