-
Notifications
You must be signed in to change notification settings - Fork 27.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update CocoaPods recommended version to 1.9 #69809
Conversation
dd3ea7c
to
8ff7d85
Compare
This seems to have worked on the builder:
|
8ff7d85
to
dcf4016
Compare
This should probably wait for #69829 to make sure the devicelab machine have a new enough version of CocoaPods but I'm tempted to yolo merge this since it shouldn't actually cause any test failures, just add the doctor warning. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tool changes LGTM.
I think the devicelab will not fail if doctor checks don't all come back positive
expect(await cocoaPodsUnderTest.evaluateCocoaPodsInstallation, CocoaPodsStatus.recommended); | ||
}); | ||
|
||
testWithoutContext('detects above recommended version', () async { | ||
pretendPodIsInstalled(); | ||
pretendPodVersionIs('1.8.1'); | ||
pretendPodVersionIs('1.9.1'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not a blocker, but should we be warning if the .z is above the recommended version?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm, what do you mean? This test shows it returning CocoaPodsStatus.recommended
which doesn't translate to a warning.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ahh, sorry, you're right.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as keeper of the gemfile.lock file, i approve of this message.
Google tests unrelated #69923 |
Description
CocoaPods 1.9 introduced support for xcframeworks. It was released in February 2020.
Flutter will likely need to start being distributed as an xcframework to support Apple Silicon simulators. Nudge people to start upgrading.
Related Issues
Fixes #69808
Fixes #69807
See #52071 for the last time this was done.
#60109
#64502
Tests
Updated cocoapods_test