Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Roll Engine from d21bb634e054 to cf376142ed5f (2 revisions) (#69976)" #69988

Merged
merged 1 commit into from Nov 6, 2020

Conversation

cbracken
Copy link
Member

@cbracken cbracken commented Nov 6, 2020

Description

Commit flutter/engine#22348 appears to have
caused breakage #69983
[tool_crash] RPCError.

This reverts commit 9edfa12.

Related Issues

#69983

Tests

n/a

Checklist

Before you create this PR, confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I signed the CLA.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Did any tests fail when you ran them? Please read Handling breaking changes.

)"

Commit flutter/engine#22348 appears to have
caused breakage flutter#69983
[tool_crash] RPCError.

This reverts commit 9edfa12.
@flutter-dashboard flutter-dashboard bot added the engine flutter/engine repository. See also e: labels. label Nov 6, 2020
@google-cla google-cla bot added the cla: yes label Nov 6, 2020
Copy link
Member

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cbracken cbracken merged commit 9b201dd into flutter:master Nov 6, 2020
@cbracken cbracken deleted the revert branch November 6, 2020 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
engine flutter/engine repository. See also e: labels.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants