New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update IntelliJ template for new projects and existing samples #7501
Conversation
I don't think we want to commit the workspace.xml file (examples/hello_services/.idea/workspace.xml) for projects other than the create template. I think that file contains settings that are more per-user specific - having it in source control would mean that you would pick up other users local settings changes, and there'd likely be a bunch of scm churn in that file. We do want files like Priming lgtm for the other changes - |
OK, that makes sense. Updated the PR to not add those. |
Still can't land this as the Travis job is timing out (unrelated to this change, I believe):
|
I don't understand why Travis did a push test on a PR. |
In any case the problem seems to be that this branch is old. You should rebase so Travis tests it against the latest test code, where I believe that race has been fixed. |
Ah, of course, will do that right away, thanks! |
Minor side note, it looks like what happened is that you checked these changes into a branch on the Flutter repo. The preferred approach is to check them into branches on your own fork of the repo. That way people don't end up pulling down your branch when they're fetching the main repo. |
Got it, will do in the future! |
Hide folders from Project View users shouldn't worry about: Fixes Project view shows many files that first-time users may be confused about flutter-intellij#630
Move
.iml
into.idea
as the user shouldn't worry about it: Fixes Migrate IML files to the .idea directory. flutter-intellij#632Add
workspace.xml
to existing examples: Followup to previous PR Add a workspace file to trigger IJ to show main.dart #7464