Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove some dynamics (mark II) #76239

Merged
merged 1 commit into from Feb 18, 2021
Merged

Conversation

Hixie
Copy link
Contributor

@Hixie Hixie commented Feb 17, 2021

...and add in some !s that were implied previously. Dynamic really is just a way to hide danger...

This is a reland of #75820 which was reverted in #76232 due to some incompatibilities with Firebase plugins. The PlatformException class' details property has been changed to dynamic rather than Object? to avoid the issue.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

...and add in some `!`s that were implied previously. Dynamic really is just a way to hide danger...
@flutter-dashboard flutter-dashboard bot added the framework flutter/packages/flutter repository. See also f: labels. label Feb 17, 2021
@google-cla google-cla bot added the cla: yes label Feb 17, 2021
@Hixie
Copy link
Contributor Author

Hixie commented Feb 17, 2021

cc @goderbauer

Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Hixie
Copy link
Contributor Author

Hixie commented Feb 18, 2021

will land if frob goes green (358040385)

@fluttergithubbot fluttergithubbot merged commit 00630d0 into flutter:master Feb 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants