[flutter_tools] cache adb path #76650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flutter-dashboard
bot
added
the
tool
jonahwilliams
commented
Feb 23, 2021
| @@ -167,7 +167,8 @@ class AndroidSdk { | |||
|
|
|||
| AndroidSdkVersion get latestVersion => _latestVersion; | |||
|
|
|||
| String get adbPath => getPlatformToolsPath(globals.platform.isWindows ? 'adb.exe' : 'adb'); | |||
There was a problem hiding this comment.
The nice thing about this approach is technically the user could still install it after the daemon starts up too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've seen a number of crashes that only seem like they can happen if the user deletes their adb while running the tool. To allow the existing process manager exceptions to handle this, cache the adb path.