Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove MockFlutterVersions #77962

Merged
merged 1 commit into from Mar 12, 2021
Merged

Remove MockFlutterVersions #77962

merged 1 commit into from Mar 12, 2021

Conversation

jmagman
Copy link
Member

@jmagman jmagman commented Mar 11, 2021 •
edited

Follow up to #77390.
Part of #71511

@jmagman jmagman self-assigned this Mar 11, 2021
@flutter-dashboard flutter-dashboard bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Mar 11, 2021
@google-cla google-cla bot added the cla: yes label Mar 11, 2021
@jmagman jmagman added team Infra upgrades, team productivity, code health, technical debt. See also team: labels. and removed cla: yes labels Mar 11, 2021
@google-cla google-cla bot added the cla: yes label Mar 11, 2021
jmagman
jmagman commented Mar 11, 2021
View reviewed changes
packages/flutter_tools/test/general.shard/flutter_platform_test.dart
@@ -122,7 +122,7 @@ void main() {
});
}

class MockSuitePlatform extends Mock implements SuitePlatform {}
class FakeSuitePlatform extends Fake implements SuitePlatform {}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unrelated to FlutterVersion but easy win.

jonahwilliams
jonahwilliams approved these changes Mar 11, 2021
View reviewed changes
Copy link
Member

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@fluttergithubbot fluttergithubbot merged commit d6f5767 into flutter:master Mar 12, 2021
@jmagman jmagman deleted the flutter-version-mock branch March 12, 2021 01:25
@jmagman jmagman mentioned this pull request Mar 13, 2021
Merged
@jmagman jmagman added the c: tech-debt Technical debt, code quality, testing, etc. label Aug 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonahwilliams jonahwilliams jonahwilliams approved these changes

Assignees

@jmagman jmagman

Labels
c: tech-debt Technical debt, code quality, testing, etc. team Infra upgrades, team productivity, code health, technical debt. See also team: labels. tool Affects the "flutter" command-line tool. See also t: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jmagman @jonahwilliams @fluttergithubbot