New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove "unnecessary" imports in test/commands.shard. #78665
Conversation
In each library where an import is removed, the library uses some elements provided by the import, BUT there is another import which provides all of the same elements, and at least one more which the library uses. In this change, we remove the imports which can be simply removed in favor of the other already present imports. See dart-lang/sdk#44569 for more information.
Looks like some tests are failing @srawlins |
Thanks, @jonahwilliams I think this is ready now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
FYI @srawlins you have a merge conflict |
This pull request is not suitable for automatic merging in its current state.
|
Sorry I think one of the bots was not flaking; @jonahwilliams this should be ready again. |
In each library where an import is removed, the library uses some elements
provided by the import, BUT there is another import which provides all of the
same elements, and at least one more which the library uses.
In this change, we remove the imports which can be simply removed in favor of
the other already present imports.
See dart-lang/sdk#44569 for more information.
List which issues are fixed by this PR. You must list at least one issue.
#74381 is improved by this issue. Not fixed.
If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.
Pre-launch Checklist
///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.