Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate Gradle repo from jcenter to mavenCentral in dev projects #78812

Merged
merged 1 commit into from Mar 23, 2021
Merged

Migrate Gradle repo from jcenter to mavenCentral in dev projects #78812

merged 1 commit into from Mar 23, 2021

Conversation

jmagman
Copy link
Member

@jmagman jmagman commented Mar 22, 2021

Replace sunsetting jcenter with mavenCentral, except for trove4j only in dev directory to work around center.bintray.com flakiness in CI.

This can be removed once trove4j is uploaded to Maven Central and we have a better migration story for Flutter apps, tracked with #78338

More context at https://youtrack.jetbrains.com/issue/IDEA-261387 and #78338 (comment).

Fixes #78354

@jmagman jmagman added tool Affects the "flutter" command-line tool. See also t: labels. t: gradle "flutter build" and "flutter run" on Android team: flakes labels Mar 22, 2021
@jmagman jmagman self-assigned this Mar 22, 2021
@flutter-dashboard flutter-dashboard bot added a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) team Infra upgrades, team productivity, code health, technical debt. See also team: labels. labels Mar 22, 2021
@google-cla google-cla bot added the cla: yes label Mar 22, 2021
jonahwilliams
jonahwilliams approved these changes Mar 22, 2021
View reviewed changes
Copy link
Member

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jmagman
Copy link
Member Author

jmagman commented Mar 23, 2021

The Cirrus cluster is borked #78678 at the moment, and the test failures are all different forms of timeouts.

I'm going it's fine since Linux framework_tests_widgets, Linux tool_tests_commands , and Linux web_integration_tests passed. I'll keep an eye on this in case there's post-submit problems.

@jmagman jmagman merged commit 2eca1f4 into flutter:master Mar 23, 2021
@jmagman jmagman deleted the maven-central-trove4j branch March 23, 2021 00:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonahwilliams jonahwilliams jonahwilliams approved these changes

Assignees

@jmagman jmagman

Labels
a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) t: gradle "flutter build" and "flutter run" on Android team Infra upgrades, team productivity, code health, technical debt. See also team: labels. tool Affects the "flutter" command-line tool. See also t: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Flaky gradle build failures
2 participants
@jmagman @jonahwilliams