Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove unnecessary String.toString() #81859

Merged
merged 1 commit into from May 7, 2021
Merged

remove unnecessary String.toString() #81859

merged 1 commit into from May 7, 2021

Conversation

a14n
Copy link
Contributor

@a14n a14n commented May 4, 2021

Follow up on #81634 (comment)

Replace unnecessary string.toString() with string.

@a14n a14n requested a review from Piinks as a code owner May 4, 2021 20:10
@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@flutter-dashboard flutter-dashboard bot added a: tests "flutter test", flutter_test, or one of our tests f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. team Infra upgrades, team productivity, code health, technical debt. See also team: labels. tool Affects the "flutter" command-line tool. See also t: labels. labels May 4, 2021
@google-cla google-cla bot added the cla: yes label May 4, 2021
@a14n a14n requested a review from Hixie May 4, 2021 20:10
Hixie
Hixie approved these changes May 5, 2021
View reviewed changes
Copy link
Contributor

@Hixie Hixie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@a14n
Copy link
Contributor Author

a14n commented May 7, 2021

Google testing — Google testing failed. Please contact a Google developer to investigate.

@Hixie could you take a look please?

@Hixie
Copy link
Contributor

Hixie commented May 7, 2021

Looks like some sort of iOS issue unrelated to your PR, but let me poke our internal folks.

@fluttergithubbot fluttergithubbot merged commit 9bca38c into flutter:master May 7, 2021
@a14n a14n deleted the remove-toString branch May 9, 2021 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hixie Hixie Hixie approved these changes

@Piinks Piinks Awaiting requested review from Piinks

Assignees
No one assigned
Labels
a: tests "flutter test", flutter_test, or one of our tests f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. team Infra upgrades, team productivity, code health, technical debt. See also team: labels. tool Affects the "flutter" command-line tool. See also t: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@a14n @Hixie @fluttergithubbot