[flutter_tools] require cmdline-tools for android licenses #82560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flutter-dashboard
bot
added
the
tool
|
In order for this change to land, all of our infra recipes would need to be updated to download the cmdline-tools |
…ine-tools-sdkmanager
…lliams/flutter into require-cmdline-tools-sdkmanager
zanderso
reviewed
May 17, 2021
| @@ -262,7 +268,7 @@ class AndroidSdk { | |||
| return null; | |||
| } | |||
|
|
|||
| String? getCmdlineToolsPath(String binaryName) { | |||
| String? getCmdlineToolsPath(String binaryName, {bool skipTools = false}) { | |||
There was a problem hiding this comment.
Is there a more specific name than skipTools for this flag? Maybe skipOldTools (supposing that I'm reading the comments in the function correctly)?
There was a problem hiding this comment.
Also does the skipTools = true case have test coverage?
|
Made the doctor check fatal, now waiting on an update to LUCI |
zanderso
approved these changes
May 17, 2021
…ine-tools-sdkmanager
…lliams/flutter into require-cmdline-tools-sdkmanager
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #80273
The latest android studio can only run the cmdline tools version of the sdk manager. Running the platform tools version will lead to an unresolvable
java.lang.NoClassDefFoundError