Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete obsolete TODO and skip #83968

Merged
merged 1 commit into from Jun 4, 2021
Merged

Delete obsolete TODO and skip #83968

merged 1 commit into from Jun 4, 2021

Conversation

dnfield
Copy link
Contributor

@dnfield dnfield commented Jun 4, 2021

This has been fixed.

@dnfield
Delete obsolete TODO and skip
48ffbe3 
This has been fixed.
@dnfield dnfield requested a review from Piinks June 4, 2021 05:32
@flutter-dashboard flutter-dashboard bot added the framework flutter/packages/flutter repository. See also f: labels. label Jun 4, 2021
@google-cla google-cla bot added the cla: yes label Jun 4, 2021
@dnfield dnfield added the team Infra upgrades, team productivity, code health, technical debt. See also team: labels. label Jun 4, 2021
Piinks
Piinks approved these changes Jun 4, 2021
View reviewed changes
Copy link
Contributor

@Piinks Piinks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Piinks
Copy link
Contributor

Piinks commented Jun 4, 2021

See #55409 for reference.

@dnfield
Copy link
Contributor Author

dnfield commented Jun 4, 2021

I think that was for a different one of these - #66289 is the todo this is fixing

@Piinks
Copy link
Contributor

Piinks commented Jun 4, 2021

I think that was for a different one of these - #66289 is the todo this is fixing

Oh whoops! You've been closing out so many TODOs I mixed them up! 😋 👍 🎉

@fluttergithubbot fluttergithubbot merged commit 5547bfd into master Jun 4, 2021
@fluttergithubbot fluttergithubbot deleted the dnfield-patch-3 branch June 4, 2021 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Piinks Piinks Piinks approved these changes

Assignees
No one assigned
Labels
framework flutter/packages/flutter repository. See also f: labels. team Infra upgrades, team productivity, code health, technical debt. See also team: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dnfield @Piinks @fluttergithubbot