Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reland "Audit hashCode overrides outside of packages/flutter"" #85567

Merged
merged 1 commit into from Jun 30, 2021
Merged

Reland "Audit hashCode overrides outside of packages/flutter"" #85567

merged 1 commit into from Jun 30, 2021

Conversation

dnfield
Copy link
Contributor

@dnfield dnfield commented Jun 29, 2021

Reverts #85451

@renyou - can you LGTM this when it is ready to go internally?

@dnfield dnfield requested a review from renyou June 29, 2021 20:09
@flutter-dashboard flutter-dashboard bot added a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) a: tests "flutter test", flutter_test, or one of our tests f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. team Infra upgrades, team productivity, code health, technical debt. See also team: labels. tool Affects the "flutter" command-line tool. See also t: labels. labels Jun 29, 2021
@google-cla google-cla bot added the cla: yes label Jun 29, 2021
@dnfield dnfield requested a review from angjieli June 30, 2021 04:18
@dnfield dnfield merged commit e36e62e into master Jun 30, 2021
@dnfield dnfield deleted the revert-85451-revert-85370-hash_codes branch June 30, 2021 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@angjieli angjieli angjieli approved these changes

@renyou renyou Awaiting requested review from renyou

Assignees
No one assigned
Labels
a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) a: tests "flutter test", flutter_test, or one of our tests f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. team Infra upgrades, team productivity, code health, technical debt. See also team: labels. tool Affects the "flutter" command-line tool. See also t: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dnfield @angjieli