Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run plugin_lint_mac task when either flutter_tools or integration_test packages change #88396

Merged
merged 1 commit into from Aug 18, 2021

Conversation

jmagman
Copy link
Member

@jmagman jmagman commented Aug 18, 2021

#88013 caused the warning:

packages/integration_test/ios/Classes/FLTIntegrationTestCase.m:34:46: note: enclose 'localizedCapitalizedString' in an @available check to silence this warning

https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8838626342733142481/+/u/run_plugin_lint_mac/test_stdout

However, the plugin_lint_mac shard was not run on presubmit on that PR, so it wasn't caught until post-submission. Run plugin_lint_mac if anything in that package, or the tool, changes.

@jmagman jmagman added a: tests "flutter test", flutter_test, or one of our tests tool Affects the "flutter" command-line tool. See also t: labels. f: integration_test The flutter/packages/integration_test plugin labels Aug 18, 2021
@jmagman jmagman self-assigned this Aug 18, 2021
@google-cla google-cla bot added the cla: yes label Aug 18, 2021
Copy link
Member

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fluttergithubbot fluttergithubbot merged commit a5a45a3 into flutter:master Aug 18, 2021
blasten pushed a commit to blasten/flutter that referenced this pull request Aug 19, 2021
@jmagman jmagman added the team Infra upgrades, team productivity, code health, technical debt. See also team: labels. label Aug 20, 2021
@jmagman jmagman deleted the plugin-lint branch August 25, 2021 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a: tests "flutter test", flutter_test, or one of our tests f: integration_test The flutter/packages/integration_test plugin team Infra upgrades, team productivity, code health, technical debt. See also team: labels. tool Affects the "flutter" command-line tool. See also t: labels.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants