Reland "Android Q transition by default (#82670)" #88409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flutter-dashboard
bot
added
f: material design
AlexV525
commented
Aug 18, 2021
| @@ -533,7 +533,7 @@ void main() { | |||
| matches(RegExp(r'^The specific RenderFlex in question is: RenderFlex#..... OVERFLOWING:$')), | |||
| startsWith(' creator: Row ← Test ← '), | |||
| contains(' ← '), | |||
| endsWith(' ← ⋯'), | |||
| endsWith(' ⋯'), | |||
There was a problem hiding this comment.
This is the fix, caused by the layout changed with the transition.
|
Let me know if I should run extra tests during the pre-submit. |
HansMuller
approved these changes
Aug 18, 2021
There was a problem hiding this comment.
The original PR - #82670 - caused a tools test failure, which I believe this PR fixes. It also caused a couple of internal golden image test failures which we can safely reset.
|
Unfortunately this caused some unexpected golden image failures on internal tests, i.e. not just failures that were obviously due to the route change animation (see internal Google issue b/197155815). We're going to have to revert again. |
HansMuller
pushed a commit
that referenced
this pull request
Aug 18, 2021
fluttergithubbot
pushed a commit
that referenced
this pull request
Aug 19, 2021
blasten
pushed a commit
to blasten/flutter
that referenced
this pull request
Aug 19, 2021
* Reland "Android Q transition by default (flutter#82670)" This reverts commit 4053b4b. * Fix `overall_experience_test.dart` for flutter_tools
blasten
pushed a commit
to blasten/flutter
that referenced
this pull request
Aug 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reland #82670 , revert #88394 , fix #88393 and #43277 . /cc @HansMuller @jmagman
Still waiting for website's instructure to be stable until submit a breaking change note.
Pre-launch Checklist
///).