Use bucket to check staging test instead of builder name #88908
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flutter-dashboard
bot
added
the
team
| @@ -112,10 +113,10 @@ class Cocoon { | |||
| } | |||
|
|
|||
| /// Only post-submit tests on `master` are allowed to update in cocoon. | |||
| bool _shouldUpdateCocoon(Map<String, dynamic> resultJson) { | |||
| bool _shouldUpdateCocoon(Map<String, dynamic> resultJson, String? buildBucket) { | |||
There was a problem hiding this comment.
When would we allow Cocoon to be updated and have this be null? Could we temporarily set a default value to prod?
There was a problem hiding this comment.
Setting a default value prod SGTM.
CaseyHillers
approved these changes
Aug 26, 2021
CaseyHillers
added a commit
that referenced
this pull request
Aug 26, 2021
)" This reverts commit d36f246.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow up of #88835. Instead of using builder name to check whether a test is from staging pool, we use
bucketto provide more flexibility.More context about naming builders without
stagingkeyword: https://flutter-review.googlesource.com/c/recipes/+/17001