Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CheckboxListTile, SwitchListTile, RadioListTile] Adds visualDensity, focusNode and enableFeedback #89353

Merged
merged 5 commits into from Sep 8, 2021
Merged

[CheckboxListTile, SwitchListTile, RadioListTile] Adds visualDensity, focusNode and enableFeedback #89353

merged 5 commits into from Sep 8, 2021

Conversation

yash1200
Copy link
Contributor

@yash1200 yash1200 commented Sep 2, 2021

This PR adds visualDensity, focusNode and enableFeedback to:

  • CheckboxListTile
  • SwitchListTile
  • RadioListTile

Fixes #88559

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt.
  • All existing and new tests are passing.

@flutter-dashboard flutter-dashboard bot added f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels Sep 2, 2021
@google-cla google-cla bot added the cla: yes label Sep 2, 2021
gspencergoog
gspencergoog approved these changes Sep 7, 2021
View reviewed changes
Copy link
Contributor

@gspencergoog gspencergoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

32384589-a60f0e74-c078-11e7-9bc1-e5b5287aea9d

Thanks for the PR!

@gspencergoog gspencergoog merged commit 36c51cb into flutter:master Sep 8, 2021
@yash1200 yash1200 deleted the focus branch September 8, 2021 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gspencergoog gspencergoog gspencergoog approved these changes

Assignees
No one assigned
Labels
f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Proposal to add visualDensity, focusNode and enableFeedback parameters to CheckboxListTile
2 participants
@yash1200 @gspencergoog