Skip to content

Conversation

@adil192
Copy link

@adil192 adil192 commented Nov 11, 2025

Updated the documentation for OpenContainer.onClosed to clarify that it is called at the start of the closing transition, not at the end.

Resolves flutter/flutter#178314

Pre-Review Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

Footnotes

  1. This PR only affects comments/documentation.

@adil192 adil192 requested a review from hannah-hyj as a code owner November 11, 2025 18:33
@github-actions github-actions bot added p: animations triage-framework Should be looked at in framework triage labels Nov 11, 2025
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the documentation for OpenContainer.onClosed to clarify that the callback is executed at the start of the closing transition, not at the end. The change correctly reflects the component's behavior. The version in pubspec.yaml and the CHANGELOG.md have been updated accordingly. I have one suggestion to make the documentation even more explicit.

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

p: animations triage-framework Should be looked at in framework triage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[animations] OpenContainer.onClosed's dartdoc implies it's called after fully closing

1 participant