Skip to content

[animations] Clarify that onClosed is called before transition #10400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 14, 2025
+5 −3
Merged

[animations] Clarify that onClosed is called before transition #10400

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c497afd
[animations] Clarify that onClosed is called before transition
adil192 Nov 11, 2025
286ed76
[animations] More explicit dartdoc from Gemini
adil192 Nov 11, 2025
62d48f2
Merge remote-tracking branch 'upstream/main' into animations/clarify-…
adil192 Nov 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/animations/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
## NEXT
## 2.1.1

* Updated the documentation for `OpenContainer.onClosed` to clarify that it is called at the start of the closing transition, not at the end.
* Updates minimum supported SDK version to Flutter 3.32/Dart 3.8.

## 2.1.0
Expand Down
3 changes: 2 additions & 1 deletion packages/animations/lib/src/open_container.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,7 +190,8 @@ class OpenContainer<T extends Object?> extends StatefulWidget {
/// * [Material.shape], which is used to implement this property.
final ShapeBorder openShape;

/// Called when the container was popped and has returned to the closed state.
/// Called when the container is popped. This is called at the start of the
/// closing transition.
Comment on lines +193 to +194
Copy link
Member

@loic-sharma loic-sharma Nov 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
/// Called when the container is popped. This is called at the start of the
/// closing transition.
/// Called when the container was popped and will return to the closed state.
///
/// This is called at the start of the closing transition.

///
/// The return value from the popped screen is passed to this function as an
/// argument.
Expand Down
2 changes: 1 addition & 1 deletion packages/animations/pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ name: animations
description: Fancy pre-built animations that can easily be integrated into any Flutter application.
repository: https://github.com/flutter/packages/tree/main/packages/animations
issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+animations%22
version: 2.1.0
version: 2.1.1

environment:
sdk: ^3.8.0
Expand Down