[path_provider] Revert iOS/macOS to plugin-based implementation

packages/path_provider/path_provider_foundation/CHANGELOG.md

@@ -1,5 +1,10 @@
+## 2.5.1
+
+* Reverts to plugin-based implementation while FFI issues are investigated.
+
 ## 2.5.0
 
+* **Retracted** due to production build issues.
 * Replaces Flutter-plugin-based implementation with direct FFI calls to
   Foundation.
 

packages/path_provider/path_provider_foundation/darwin/RunnerTests/RunnerTests.swift

@@ -0,0 +1,90 @@
+// Copyright 2013 The Flutter Authors
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+import XCTest
+
+@testable import path_provider_foundation
+
+#if os(iOS)
+  import Flutter
+#elseif os(macOS)
+  import FlutterMacOS
+#endif
+
+class RunnerTests: XCTestCase {
+  func testGetTemporaryDirectory() throws {
+    let plugin = PathProviderPlugin()
+    let path = plugin.getDirectoryPath(type: .temp)
+    XCTAssertEqual(
+      path,
+      NSSearchPathForDirectoriesInDomains(
+        FileManager.SearchPathDirectory.cachesDirectory,
+        FileManager.SearchPathDomainMask.userDomainMask,
+        true
+      ).first)
+  }
+
+  func testGetApplicationDocumentsDirectory() throws {
+    let plugin = PathProviderPlugin()
+    let path = plugin.getDirectoryPath(type: .applicationDocuments)
+    XCTAssertEqual(
+      path,
+      NSSearchPathForDirectoriesInDomains(
+        FileManager.SearchPathDirectory.documentDirectory,
+        FileManager.SearchPathDomainMask.userDomainMask,
+        true
+      ).first)
+  }
+
+  func testGetApplicationSupportDirectory() throws {
+    let plugin = PathProviderPlugin()
+    let path = plugin.getDirectoryPath(type: .applicationSupport)
+    #if os(iOS)
+      // On iOS, the application support directory path should be just the system application
+      // support path.
+      XCTAssertEqual(
+        path,
+        NSSearchPathForDirectoriesInDomains(
+          FileManager.SearchPathDirectory.applicationSupportDirectory,
+          FileManager.SearchPathDomainMask.userDomainMask,
+          true
+        ).first)
+    #else
+      // On macOS, the application support directory path should be the system application
+      // support path with an added subdirectory based on the app name.
+      XCTAssert(
+        path!.hasPrefix(
+          NSSearchPathForDirectoriesInDomains(
+            FileManager.SearchPathDirectory.applicationSupportDirectory,
+            FileManager.SearchPathDomainMask.userDomainMask,
+            true
+          ).first!))
+      XCTAssert(path!.hasSuffix("Example"))
+    #endif
+  }
+
+  func testGetLibraryDirectory() throws {
+    let plugin = PathProviderPlugin()
+    let path = plugin.getDirectoryPath(type: .library)
+    XCTAssertEqual(
+      path,
+      NSSearchPathForDirectoriesInDomains(
+        FileManager.SearchPathDirectory.libraryDirectory,
+        FileManager.SearchPathDomainMask.userDomainMask,
+        true
+      ).first)
+  }
+
+  func testGetDownloadsDirectory() throws {
+    let plugin = PathProviderPlugin()
+    let path = plugin.getDirectoryPath(type: .downloads)
+    XCTAssertEqual(
+      path,
+      NSSearchPathForDirectoriesInDomains(
+        FileManager.SearchPathDirectory.downloadsDirectory,
+        FileManager.SearchPathDomainMask.userDomainMask,
+        true
+      ).first)
+  }
+}

packages/path_provider/path_provider_foundation/darwin/path_provider_foundation.podspec

@@ -0,0 +1,26 @@
+#
+# To learn more about a Podspec see http://guides.cocoapods.org/syntax/podspec.html
+#
+Pod::Spec.new do |s|
+  s.name             = 'path_provider_foundation'
+  s.version          = '0.0.1'
+  s.summary          = 'An iOS and macOS implementation of the path_provider plugin.'
+  s.description      = <<-DESC
+  An iOS and macOS implementation of the Flutter plugin for getting commonly used locations on the filesystem.
+                       DESC
+  s.homepage         = 'https://github.com/flutter/packages/tree/main/packages/path_provider/path_provider_foundation'
+  s.license          = { :type => 'BSD', :file => '../LICENSE' }
+  s.author           = { 'Flutter Dev Team' => 'flutter-dev@googlegroups.com' }
+  s.source           = { :http => 'https://github.com/flutter/packages/tree/main/packages/path_provider/path_provider_foundation' }
+  s.source_files = 'path_provider_foundation/Sources/path_provider_foundation/**/*.swift'
+  s.ios.dependency 'Flutter'
+  s.osx.dependency 'FlutterMacOS'
+  s.ios.deployment_target = '13.0'
+  s.osx.deployment_target = '10.15'
+  s.ios.xcconfig = {
+    'LIBRARY_SEARCH_PATHS' => '$(TOOLCHAIN_DIR)/usr/lib/swift/$(PLATFORM_NAME)/ $(SDKROOT)/usr/lib/swift',
+    'LD_RUNPATH_SEARCH_PATHS' => '/usr/lib/swift',
+  }
+  s.swift_version = '5.0'
+  s.resource_bundles = {'path_provider_foundation_privacy' => ['path_provider_foundation/Sources/path_provider_foundation/Resources/PrivacyInfo.xcprivacy']}
+end

packages/path_provider/path_provider_foundation/darwin/path_provider_foundation/Package.swift

@@ -0,0 +1,28 @@
+// swift-tools-version: 5.9
+
+// Copyright 2013 The Flutter Authors
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+import PackageDescription
+
+let package = Package(
+  name: "path_provider_foundation",
+  platforms: [
+    .iOS("13.0"),
+    .macOS("10.15"),
+  ],
+  products: [
+    .library(name: "path-provider-foundation", targets: ["path_provider_foundation"])
+  ],
+  dependencies: [],
+  targets: [
+    .target(
+      name: "path_provider_foundation",
+      dependencies: [],
+      resources: [
+        .process("Resources")
+      ]
+    )
+  ]
+)

packages/path_provider/path_provider_foundation/darwin/path_provider_foundation/Sources/path_provider_foundation/PathProviderPlugin.swift

@@ -0,0 +1,75 @@
+// Copyright 2013 The Flutter Authors
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+import Foundation
+
+#if os(iOS)
+  import Flutter
+#elseif os(macOS)
+  import FlutterMacOS
+#endif
+
+public class PathProviderPlugin: NSObject, FlutterPlugin, PathProviderApi {
+  public static func register(with registrar: FlutterPluginRegistrar) {
+    let instance = PathProviderPlugin()
+    // Workaround for https://github.com/flutter/flutter/issues/118103.
+    #if os(iOS)
+      let messenger = registrar.messenger()
+    #else
+      let messenger = registrar.messenger
+    #endif
+    PathProviderApiSetup.setUp(binaryMessenger: messenger, api: instance)
+  }
+
+  func getDirectoryPath(type: DirectoryType) -> String? {
+    var path = getDirectory(ofType: fileManagerDirectoryForType(type))
+    #if os(macOS)
+      // In a non-sandboxed app, these are shared directories where applications are
+      // expected to use its bundle ID as a subdirectory. (For non-sandboxed apps,
+      // adding the extra path is harmless).
+      // This is not done for iOS, for compatibility with older versions of the
+      // plugin.
+      if type == .applicationSupport || type == .applicationCache {
+        if let basePath = path {
+          let basePathURL = URL.init(fileURLWithPath: basePath)
+          path = basePathURL.appendingPathComponent(Bundle.main.bundleIdentifier!).path
+        }
+      }
+    #endif
+    return path
+  }
+
+  // Returns the path for the container of the specified app group.
+  func getContainerPath(appGroupIdentifier: String) -> String? {
+    return FileManager.default.containerURL(
+      forSecurityApplicationGroupIdentifier: appGroupIdentifier)?.path
+  }
+}
+
+/// Returns the FileManager constant corresponding to the given type.
+private func fileManagerDirectoryForType(_ type: DirectoryType) -> FileManager.SearchPathDirectory {
+  switch type {
+  case .applicationCache:
+    return FileManager.SearchPathDirectory.cachesDirectory
+  case .applicationDocuments:
+    return FileManager.SearchPathDirectory.documentDirectory
+  case .applicationSupport:
+    return FileManager.SearchPathDirectory.applicationSupportDirectory
+  case .downloads:
+    return FileManager.SearchPathDirectory.downloadsDirectory
+  case .library:
+    return FileManager.SearchPathDirectory.libraryDirectory
+  case .temp:
+    return FileManager.SearchPathDirectory.cachesDirectory
+  }
+}
+
+/// Returns the user-domain directory of the given type.
+private func getDirectory(ofType directory: FileManager.SearchPathDirectory) -> String? {
+  let paths = NSSearchPathForDirectoriesInDomains(
+    directory,
+    FileManager.SearchPathDomainMask.userDomainMask,
+    true)
+  return paths.first
+}

packages/path_provider/path_provider_foundation/darwin/path_provider_foundation/Sources/path_provider_foundation/Resources/PrivacyInfo.xcprivacy

@@ -0,0 +1,14 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
+<plist version="1.0">
+<dict>
+	<key>NSPrivacyTrackingDomains</key>
+	<array/>
+	<key>NSPrivacyAccessedAPITypes</key>
+	<array/>
+	<key>NSPrivacyCollectedDataTypes</key>
+	<array/>
+	<key>NSPrivacyTracking</key>
+	<false/>
+</dict>
+</plist>